refine_issue_note_link.diff

YOSHITANI Mitsuhiro, 2013-06-01 08:53

Download (2.86 KB)

View differences:

app/helpers/application_helper.rb
699 699
          when nil
700 700
            if oid.to_s == identifier && issue = Issue.visible.find_by_id(oid, :include => :status)
701 701
              anchor = comment_id ? "note-#{comment_id}" : nil
702
              link = link_to("##{oid}", {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid, :anchor => anchor},
702
              link = link_to(h("##{oid}#{comment_suffix}"), {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid, :anchor => anchor},
703 703
                                        :class => issue.css_classes,
704 704
                                        :title => "#{truncate(issue.subject, :length => 100)} (#{issue.status.name})")
705 705
            end
test/unit/helpers/application_helper_test.rb
268 268
  def test_redmine_links
269 269
    issue_link = link_to('#3', {:controller => 'issues', :action => 'show', :id => 3},
270 270
                               :class => Issue.find(3).css_classes, :title => 'Error 281 when updating a recipe (New)')
271
    note_link = link_to('#3', {:controller => 'issues', :action => 'show', :id => 3, :anchor => 'note-14'},
271
    note_link = link_to('#3-14', {:controller => 'issues', :action => 'show', :id => 3, :anchor => 'note-14'},
272
                               :class => Issue.find(3).css_classes, :title => 'Error 281 when updating a recipe (New)')
273
    note_link2 = link_to('#3#note-14', {:controller => 'issues', :action => 'show', :id => 3, :anchor => 'note-14'},
272 274
                               :class => Issue.find(3).css_classes, :title => 'Error 281 when updating a recipe (New)')
273 275

  
274 276
    revision_link = link_to('r1', {:controller => 'repositories', :action => 'revision', :id => 'ecookbook', :rev => 1},
......
311 313
      '#3, [#3], (#3) and #3.'      => "#{issue_link}, [#{issue_link}], (#{issue_link}) and #{issue_link}.",
312 314
      # ticket notes
313 315
      '#3-14'                       => note_link,
314
      '#3#note-14'                  => note_link,
316
      '#3#note-14'                  => note_link2,
315 317
      # should not ignore leading zero
316 318
      '#03'                         => '#03',
317 319
      # changesets
318
-