From 59296c8deee70ee836f92d3cdf7337ae34b259d4 Mon Sep 17 00:00:00 2001 From: Marius BALTEANU Date: Wed, 15 Aug 2018 19:12:41 +0000 Subject: [PATCH 2/2] Show version status as badge in rodmap#index and roadmap#show --- app/views/versions/index.html.erb | 1 + app/views/versions/show.html.erb | 5 +++-- public/stylesheets/application.css | 13 +++++++++++++ test/functional/versions_controller_test.rb | 5 ++++- 4 files changed, 21 insertions(+), 3 deletions(-) diff --git a/app/views/versions/index.html.erb b/app/views/versions/index.html.erb index eeb9f3f..429bc5b 100644 --- a/app/views/versions/index.html.erb +++ b/app/views/versions/index.html.erb @@ -18,6 +18,7 @@ <% end %>

<%= link_to_version version, :name => version_anchor(version) %>

+ <%= l("version_status_#{version.status}") %>
<%= render :partial => 'versions/overview', :locals => {:version => version} %> <%= render(:partial => "wiki/content", diff --git a/app/views/versions/show.html.erb b/app/views/versions/show.html.erb index 677cc14..ad3ed25 100644 --- a/app/views/versions/show.html.erb +++ b/app/views/versions/show.html.erb @@ -5,9 +5,10 @@ <%= call_hook(:view_versions_show_contextual, { :version => @version, :project => @project }) %> -

<%= @version.name %>

-
+

<%= @version.name %>

+ <%= l("version_status_#{@version.status}") %> + <%= render :partial => 'versions/overview', :locals => {:version => @version} %> <%= render(:partial => "wiki/content", :locals => {:content => @version.wiki_page.content}) if @version.wiki_page %> diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css index ac68790..d663640 100644 --- a/public/stylesheets/application.css +++ b/public/stylesheets/application.css @@ -550,6 +550,7 @@ div#roadmap .related-issues td.checkbox { display: none; } div#roadmap .wiki h1:first-child { display: none; } div#roadmap .wiki h1 { font-size: 120%; } div#roadmap .wiki h2 { font-size: 110%; } +div#roadmap h2, div#roadmap h3 { display: inline; padding-right: 0;} body.controller-versions.action-show div#roadmap .related-issues {width:70%;} div#version-summary { float:right; width:28%; margin-left: 16px; margin-bottom: 16px; background-color: #fff; } @@ -1252,6 +1253,7 @@ div.wiki img {vertical-align:middle; max-width:100%;} bottom: 2px; padding: 0px 2px 0px 2px; margin-right: 2px; + margin-left: 2px; border-radius: 2px; text-transform: uppercase; text-decoration: none; @@ -1264,6 +1266,17 @@ div.wiki img {vertical-align:middle; max-width:100%;} color: #fff; background:#9DB9D5; } +.badge-status-open { + color: #fff; + background: #559cec; +} +.badge-status-locked { + background: #EEEEEE; +} +.badge-status-closed { + color: #fff; + background: #51ce39; +} /***** Icons *****/ .icon { background-position: 0% 50%; diff --git a/test/functional/versions_controller_test.rb b/test/functional/versions_controller_test.rb index 3d5af8d..3a37f90 100644 --- a/test/functional/versions_controller_test.rb +++ b/test/functional/versions_controller_test.rb @@ -34,7 +34,9 @@ class VersionsControllerTest < Redmine::ControllerTest assert_response :success # Version with no date set appears - assert_select 'h3', :text => Version.find(3).name + assert_select 'h3', :text => "#{Version.find(3).name}" + assert_select 'span[class=?]', 'badge badge-status-open', :text => 'open' + # Completed version doesn't appear assert_select 'h3', :text => Version.find(1).name, :count => 0 @@ -99,6 +101,7 @@ class VersionsControllerTest < Redmine::ControllerTest assert_response :success assert_select 'h2', :text => /1.0/ + assert_select 'span[class=?]', 'badge badge-status-locked', :text => 'locked' end def test_show_issue_calculations_should_take_into_account_only_visible_issues -- 2.1.4