From a18b577b79a948b7a12d92872aaf72de69afd5ea Mon Sep 17 00:00:00 2001 From: MAEDA Go Date: Mon, 19 Sep 2022 18:17:30 +0900 Subject: [PATCH 1/2] Get attachments with single query when rendering a journal --- app/models/journal.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/models/journal.rb b/app/models/journal.rb index 919a07dd2..a4efcdbee 100644 --- a/app/models/journal.rb +++ b/app/models/journal.rb @@ -142,7 +142,8 @@ class Journal < ActiveRecord::Base end def attachments - details.select{ |d| d.property == 'attachment' }.map{ |d| Attachment.find_by(:id => d.prop_key) }.compact + ids = details.select {|d| d.property == 'attachment' && d.value.present?}.map(&:prop_key) + Attachment.where(id: ids).to_a end # Returns a string of css classes -- 2.34.1