Issue Closed Date

Added by Chris Darts over 3 years ago

I have been trying to install the 'Issue Closed Date' plugin (http://www.redmine.org/plugins/closed_date), but seem to be having problems getting it to work with Redmine v1.1.2.

After installation, when clicking on the 'Issues' tab for a specific project I receive the following error:

NoMethodError in Issues#index

Showing app/views/queries/_filters.rhtml where line #75 raised:

undefined method `[]' for :date:Symbol

Extracted source (around line #75):

72: <tr>
73: <td>
74: <table>
75: <% query.available_filters.sort{|a,b| a[1][:order]<=>b[1][:order]}.each do |filter| %>
76:     <% field = filter[0]
77:        options = filter[1] %>
78:     <tr <%= 'style="display:none;"' unless query.has_filter?(field) %> id="tr_<%= field %>" class="filter">

Trace of template inclusion: app/views/issues/index.rhtml

Any ideas? I've posted the same problem on the author's github issue list, but so far have received no response.

Replies (26)

RE: Issue Closed Date - Added by J. R. over 3 years ago

I'm seeing the same stuff on Redmine 1.0.5.stable (MySQL).
Any ideas how to tackle that?

RE: Issue Closed Date - Added by Matheus Ashton Silva over 3 years ago

Im working to fix this bug, i'll release the fixed version soon as possible

RE: Issue Closed Date - Added by J. R. over 3 years ago

Thanks, Matheus! Looking forward for your fix, and that's not just me :)

RE: Issue Closed Date - Added by Chris Darts over 3 years ago

Matheus Ashton Silva wrote:

Im working to fix this bug, i'll release the fixed version soon as possible

Thanks Matheus. This is a great addition to Redmine and will be extremely useful once it's working.

RE: Issue Closed Date - Added by Matheus Ashton Silva over 3 years ago

I believe i have fixed the bug, please check it out and tell me if theres anything else i can do..

RE: Issue Closed Date - Added by J. R. over 3 years ago

Metheus, thanks for this! Great job, tried the new version on my Redmine v1.0.5 and it works perfectly, no glitches noted, apart from the lack of English translation, but that could easily be fixed by putting this in plugin's config/locales/en.yml:

en:
  field_start_end_date: "Start/End" 
  field_closed_date: "Closed"

...and regarding something else that can be done to make this plugin even more awesome :) Could it be possible to store/show not only the date, but also the time of closure, just as for the Created and Updated fields? It would be both logical and useful, I think.

Screenshot

screen.jpg - Screenshot (9.06 KB)

RE: Issue Closed Date - Added by J. R. over 3 years ago

I've got two news :)

  • Good one - the updated version of the plugin works also on Redmine v1.1.3.
  • Bad one - there seems to be a bug; if you select more than one issue and close them all at once via a right-click menu, then the "Closed" field does not get updated and remains empty. That behavior manifests in both Redmine v1.0.5 and v1.1.3.

RE: Issue Closed Date - Added by Matheus Ashton Silva over 3 years ago

RE: Issue Closed Date - Adicionado por J. R. aproximadamente 11 horas atrás

Metheus, thanks for this! Great job, tried the new version on my Redmine v1.0.5 and it works perfectly, no glitches noted, apart from the lack of English translation, but that could easily be fixed by putting this in plugin's config/locales/en.yml:

en:
field_start_end_date: "Start/End"
field_closed_date: "Closed"

...and regarding something else that can be done to make this plugin even more awesome :) Could it be possible to store/show not only the date, but also the time of closure, just as for the Created and Updated fields? It would be both logical and useful, I think.

Thanks, i will add the english translation, and the time to the closed date field

RE: Issue Closed Date - Adicionado por J. R. aproximadamente 10 horas atrás

I've got two news :)

Good one - the updated version of the plugin works also on Redmine v1.1.3.

Bad one - there seems to be a bug; if you select more than one issue and close them all at once via a right-click menu, then the "Closed" field does not get updated and remains empty. That behavior manifests in both Redmine v1.0.5 and v1.1.3.

Thanks for the warning, I'll start to work on that bug soon as I can

RE: Issue Closed Date - Added by Chris Darts over 3 years ago

I'm happy to confirm this now works fine on Redmine v1.1.3.

Thanks Matheus for this great plugin.

RE: Issue Closed Date - Added by Luis Felipe Salin Monteiro about 3 years ago

Hello Matheus,

I installed your plugin, but I realized that it is not exporting the 'closed date' field in the CSV report. It would be great to have the field in this report since the data is used to create graphs and pivot tables.

How can I do that?

BR.

RE: Issue Closed Date - Added by Alexander Kulemin about 3 years ago

Luis Felipe Salin Monteiro wrote:

Hello Matheus,

I installed your plugin, but I realized that it is not exporting the 'closed date' field in the CSV report. It would be great to have the field in this report since the data is used to create graphs and pivot tables.

How can I do that?

Hello!

If I not mistaken, in Redmine without patch you can export in csv-report only fixed column collection. I have redmine patch, that I created for exporting last comment's field for every issue. May be, it's can help you.. At least, with this patch now I can export 'closing date' field in csv. But I don't tried it without patch :)

RE: Issue Closed Date - Added by Francisco José Martínez about 3 years ago

I've forked your project to fix the right-click menu :)

RE: Issue Closed Date - Added by Matheus Ashton Silva about 3 years ago

Thanks for the help Francisco,

I've been very busy lately and to make things worst, my notebook broke, but the plugin wasn't not discontinued, now that I put my things in order, you can report any bug, or suggest any feature that I will code it to make the plugin better and better. Thanks for all those help with the issues reported until now.

Just one more thing, for my better control, I just ask you to open issues on the GitHub's project page: https://github.com/ashton/redmine_closed_issue

RE: Issue Closed Date - Added by Matheus Ashton Silva about 3 years ago

Luiz Felipe,

I'm working on the CSV and PDF export, soon as I have news, I'll post it on here

RE: Issue Closed Date - Added by Matheus Ashton Silva about 3 years ago

Someone has tested on 1.2.1 version?

RE: Issue Closed Date - Added by Luis Felipe Salin Monteiro about 3 years ago

Hi Ashton, any news on the CSV report? BR

RE: Issue Closed Date - Added by Luis Felipe Salin Monteiro about 3 years ago

I identified a problem. The plugin reset the closed date when an update is made on the issue, even when the update do not change the status. Is there any fix for that

RE: Issue Closed Date - Added by Alexander Kulemin about 3 years ago

Luis Felipe Salin Monteiro wrote:

I identified a problem. The plugin reset the closed date when an update is made on the issue, even when the update do not change the status. Is there any fix for that

You can use it:

Index: C:/Program Files/BitNami Redmine Stack/apps/redmine/vendor/plugins/redmine_closed_issue/lib/close_issue_patch.rb
===================================================================
--- C:/Program Files/BitNami Redmine Stack/apps/redmine/vendor/plugins/redmine_closed_issue/lib/close_issue_patch.rb    (revision 104)
+++ C:/Program Files/BitNami Redmine Stack/apps/redmine/vendor/plugins/redmine_closed_issue/lib/close_issue_patch.rb    (revision 105)
@@ -1,21 +1,22 @@
 module ClosedDateIssue
   class Hooks < Redmine::Hook::ViewListener
     def controller_issues_new_before_save(context)
-      save_closed_date(context)
+      save_closed_date(context) 
     end

     def controller_issues_edit_before_save(context)
-      save_closed_date(context)
+      save_closed_date(context) if context[:issue].status_id_changed?
     end

     def save_closed_date(context)
       if(context[:issue])
         closed_statuses = IssueStatus.find(:all, :conditions => { :is_closed => true })
         find = closed_statuses.find_all { |obj| obj.id == context[:issue].status.id}
-        if(context[:issue].status.id ==  closed_statuses or (closed_statuses.instance_of? Array and find.size() > 0))
+#        if(context[:issue].status.id ==  closed_statuses or (closed_statuses.instance_of? Array and find.size() > 0))
+     if context[:issue].closing? 
           context[:issue].closed_date = Time.now
         else
-          context[:issue].closed_date = nil if(context[:issue].closed_date)
+          context[:issue].closed_date = nil if(context[:issue].closed_date) if context[:issue].reopened?
         end
       end
     end

RE: Issue Closed Date - Removes "Related Issues" - Added by Gary Barclay over 2 years ago

Hi,
Just in case you are still developing this plugin, I have noticed after installing that it removes the "Related Issues" option on the issue details page.

A great plugin but I'm afraid the "Related issues" is too important a feature to lose.

Using:
- Redmine 1.3.0-1
- Apache 2.2.21
- ImageMagick 6.5.8
- MySQL 5.5.16
- Subversion 1.7.1
- Ruby 1.8.7-p334
- Rails 2.3.14
- RubyGems 1.6.2

RE: Issue Closed Date - Added by Dmitry K over 2 years ago

"Related issues" removed after plagin installation.

Redmine 1.4.1.stable

RE: Issue Closed Date - Added by Anders Wallin over 2 years ago

Hi,

The reason "related issues" is removed by this plugin is that it replaces the file app/views/issues/show.rhtml and the plugin version of this file is based on an old redmine version. The easiest solution to your problem is to just remove this file from the plugin folder (i.e. vendor/plugins/issue_close_date/app/views/issues/show.rhtml) because the only thing it does is to add closed date to the issue view and I think you can live without it. You can see from the issue history when the issue was closed anyway.

Note that the plugin also replaces show.api.rsb in the same folder but there hasn't been any changes to this file in Redmine since the plugin was developed so you can leave it as it is.

Hope it helps.

RE: Issue Closed Date - Added by Dmitry K over 2 years ago

Anders Wallin wrote:

Hi,
............
Hope it helps.

Thank you, it works!

RE: Issue Closed Date - Added by Matheus Ashton Silva over 2 years ago

Hi Guys,

I'm going to update the plugin to the newest versions of redmine, I've been very busy lately so I didn't have time to do this yet, but don't worry, the plugin isn't discontinued, I'll keep suporting it to the new versions of redmine.

RE: Issue Closed Date - Added by Martin G over 2 years ago

The attached file should work with Redmine 1.3.1

show.rhtml Magnifier (5.52 KB)

RE: Issue Closed Date - Added by Martin G almost 2 years ago

Does the plugin now support 2.x?

1 2 (1-25/26)