Weekly Timesheet Plugin (wk-time)

Added by Alfredo Bonilla almost 6 years ago

I've created this entry for having several requests for this good plugin. Very useful. Here are my considerations:

  • The activites shown do not correspond to the active ones for the selected project. They should be reloaded with the right ones for the selected project
  • The user displayed in the User Lists, should be the current one (by default)
  • The layout is displaying info requiring a not really confortable horizontal scroll

Replies (59)

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian almost 6 years ago

when you say active issues - do you mean do not show any closed issues, there was anotehr request in the forum ( http://www.redmine.org/boards/3/topics/28282 ).
on the layout, which version of browser and screen size are you using

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla almost 6 years ago

About the activities, I mean the activities available for the project (project settings/activities(time tracking)), like Development, Design, Testing, etc. We have different activities in some projects, so in the same way than the list of issues is updated when the project changes, the activities should be updated just with the list of available activities for the new project selected.

About, the layout, I've tested with IE8: here is worst, because no scroll is shown, and with Chrome, where there is a scroll bar, but the appareance, is not really good.

Chrome layout.PNG (16.3 KB)

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla almost 6 years ago

Hi again,

the plugin has an error related to the time logged directly to the Project. In these entries, the issue is empty (nil) and the SAVE option fails:

TypeError (can't convert nil into String):
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:216:in `+'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:216:in `gatherEntries'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:213:in `each'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:213:in `each_with_index'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:213:in `gatherEntries'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:209:in `each'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:209:in `each_with_index'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:209:in `gatherEntries'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:83:in `update'
  vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:81:in `update'
  config/initializers/mongrel.rb:62:in `dispatch_cgi'

Additionally, the time logged directly to the project, is displayed in the weekly table, but adding a project issue... If the SAVE option is executed, the time logged to the project is MOVED to the displayed issue.

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian almost 6 years ago

hey, can you check in version 0.0.5 (we just released that), the problem not seem to exist on 0.0.5

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla almost 6 years ago

Thanks for your new 0.0.5 release. Nevertheless, the problem is still there. I try to summarize:

  • Logging Time to Project I - Execution Error: The problem still remains. If you try to log time directly to a Project (that has any issue), you still have the same error (previous entry).
  • Logging Time to Project II - Not possible if the project has any issue. It just requires to add ":include_blank => true" in the select field
  • Cleaning an already saved entry. The problem happens cleaning an already created entry. Instead of treating the new value as '0.0', is treating it as nil, with the corresponding execution error.
ActionView::TemplateError (nil can't be coerced into Float) on line #56 of vendor/plugins/redmine_wktime/app/views/wktime/_edit_issues.rhtml:

The work around consists in settign 0 instead of leaving it empty.

  • Layout - About the layout, what about to remove the comments column? Maybe it could be shown as a tooltip when you set the cursor on the issue field... for example. I'm just trying to collapse the row length.

Again,
Thanks again for your great work

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian almost 6 years ago

If you empty the hours, it will delete that entry from db, it has always worked. I have just tested as well. It works fine. If you still have the problem, please let me know the steps to recreate the problem.

Yeah, on the layout, I was thinking about the same, move the comments to a popup or tooltip.

I got an email saying that the problem with entering time directly to project is fixed, please confirm.

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla almost 6 years ago

I've tried with Redmine 1.2.2 and 1.3.0 stable versions and these are the current problems:

  • Log time to a Project without any issue gives this error: "can't convert nil into String" in "vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:229:in `+'"

Work-around, log time directly from the project overview form

  • In this situation: 4 hours logged to one issue on Tuesday. Save. Ok. Later you see that the hours should be logged to a different activity. Edit, add Row, empty the 4 hours and set them in the new row. With these steps you get the error "undefined method `+' for nil:NilClass" in "vendor/plugins/redmine_wktime/app/controllers/wktime_controller.rb:234:in `gatherEntries'"

Work-around, empty the hours, save and later edit again to add the removed hours in a different row

Finally, and related to logging hours to a project, it should be interesting to allow the "blank" selection on the issues list.

RE: Weekly Timesheet Plugin (wk-time) - Added by Anonymous over 5 years ago

Hi,

Firstly, I really like this timesheet plugin.

However, we have some really long issues in our redmine DB and I wanted to find out how to set the issue column to be left justified and limited to only display a 32 char width.

Screen shot attached displaying the display problem.

Thanks for this awesome plugin! Can't wait to see more!

-John

25-Jan-12 2-36-08 PM.png - screen shot of issue with "Issues" display (44.7 KB)

RE: Weekly Timesheet Plugin (wk-time) - Added by Anonymous over 5 years ago

Hi - regarding the Issues: column

we edited the application.css for our current style and set the .issue to width:250px

}
input[type="submit"] {
padding: 4px 12px;
}
.issue select{
width:250px !important;
}

This will of course not work if we switch themes - but it does the trick for now.

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

JP,
thanks for your feedback.
I will set the width as follows
project dropdown - 150px
issue dropdown - 250px
activity dropdown - 75px

Let me know if you think otherwise.

And will be part of 0.0.6 release.

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Alfredo,
I can reproduce the problem #1 ,related to empty project with no issues (I have put in a fix and will be part of 0.0.6). but I am unable to reproduce problem #2, related to adding the row and changing the hour. Could you please give me more details on problem #2.

thanks

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Anonymous over 5 years ago

Thank you very much, Dhanasingh!

We are looking forward to the 0.0.6 release as I think your plugin will be a better timesheet method for our team.

Cheers,
John

Dhanasingh Krishnapandian wrote:

JP,
thanks for your feedback.
I will set the width as follows
project dropdown - 150px
issue dropdown - 250px
activity dropdown - 75px

Let me know if you think otherwise.

And will be part of 0.0.6 release.

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla over 5 years ago

Dhanasingh,

I've found some mistmach between the total number of hours spent and the ones detailed in the weekly plugin: it is related to having 2 time entries "repeated" (same day, same activity, same issue_id, same number of hours, but different time_entry_id, of course)

  • The total number of hours displayed in the "index" view is right, but
  • The detailed number of hours displayed in the "edit" view is missing this "repeated" time entry

Good news to hear about this new 0.0.6 release. Probably solving the first incident, the second one dissapears. This last error was related to "playing" with the hours in rows where the issue-id is empty (because we are talking about a project without issues or about a direct log against the project (without setting the issue)).

For us it would be really important the capability of logging time from the plugin directly to the project, I mean, leaving empty the Issue field. This is not possible in 0.0.5 release.

Thanks in advance for your great work

RE: Weekly Timesheet Plugin (wk-time) - Added by Alexander Schramm over 5 years ago

Dhanasingh,

first of all, thank you for that plugin. It saves us a lot of time when logging spent hours!! ;-)

As we tested the plugin now for 2 weeks, we have two things, that would be a great improvement for us:

1.) At the moment, the first page displays all the logged weeks. This is great for our reporters, but for our employees with the role "Manager" or "Administrator" it is a bit confusing to find their own logged weeks as at this point as all the entries of many other employees are displayed. It would be great, if there would be an option to select only a specific user. If a specific user is selected, it should automatically update the displayed weeks (as it already does if a different date range is selected). I think this would be a great enhancement.

2.) The second thing is maybe very specific to our way using Redmine: Would it be possible that there is an option to pre-fill a new week based on the used projects, issues and actitivties of the last logged week? Or instead of that, to add a "copy" or "clone" button if a logged week is displayed?

Again, thanks for the work you made!!

Alex

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Alfredo,
Regarding the hours from duplicate entries, We have already mentioned this in the description of the plugin.
The wk-time plugin only allows one entry per project/issue/activity/date combination, but the core time entry page allows multiple time entries for the project/issue/activity/date combination. So if you have entered multiple entries for a project/issue/activity/date combination and try to open that with wk-time plugin, it will show only one.

This is a design constraint we have in the plugin. I don't think we can put in a quick-fix now, we will address this at a later point.

Although if you enter multiple entries for a project/issue/activity/date combination on a new wk-time timesheet, it will sum up all the hours and save it as one entry.

Thanks for bringing it up,

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Alex,
Thanks for your feedback.
On your two request, the #1 should be a simple one, we will try to put that in next release 0.0.6. The request #2 might take some time, we will try to put that in a future release.

thanks

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Version 0.0.6 is released, please take a look and let me know your feedback.

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla over 5 years ago

Hi, the plugin is really improving day by day. It's great. Perfect layout now.

We still miss the possibility of logging time directly to the project. We patched the plugin with these 2 mods:

views/_edit_issues2.rhtml - line 24. Add an extra empty element

   issues << [" "]

views/edit.html.erb - updateDropdown js function - line 34. After for loop, add an extra empty element

   // Add an empty element for allowing blank issue logging
   dropdown[row-1].options[i] = new Option( "  " )

With these mods the plugin can log times to the project in the same way than from "overview-details-log", that is, with an empty issue.

Finally, it would be great filtering bu User.current when accessing to the plugin. You could add some "All" ficticious user with id=0 for allowing a filter without user...

Best Regards

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Alfredo,
How do you want the duplicate entries (same day, same issue and same activity) handled?
Can we just show the duplicate entries also in the timesheet ?

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Alfredo Bonilla over 5 years ago

Maybe you could just add the hours without showing any extra row. In this way the sum of hours in the index and in the weekly form would be the same. In case of detecting same day, issue and activity, instead of adding a new row, add the hours to the existing one.

I know that this is easier to say than to do it :)

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

yeah, I know :-)
it might be easier to just repeat the same project/issue/activity/day entries rather than summing up.
There is already another request by another community user on this item.
I will what can be done.

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

Alfredo,
I have put in the code for allowing time entries to projects with no issues. this will be part of next release 0.0.7
For now I am going to just show the duplicate entries in separate rows, thats easier, this will also be part of 0.0.7 as well.

Alex,
using previous week's template for new timesheet feature will be part of next release 0.0.7. you already know this.

Dhanasingh

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

version 0.0.7 is released, please take a look.

RE: Weekly Timesheet Plugin (wk-time) - Added by Krzysztof Rosiński over 5 years ago

It would be perfect if it will be possible to use a specific custom field as a field (like project/issue). We are using issue custom field to put identifiers of clients who are paying for the development, and later we want to get the weekly timesheet with number of hours per every one id from this group. So it would be a killer feature for me if I can group entries by specific custom field and export the work hours.

RE: Weekly Timesheet Plugin (wk-time) - Added by Dhanasingh Krishnapandian over 5 years ago

I think this should be an option on the spent time report within redmine core. Currently the report lets you group by project, issue, activity etc, if you are able to add your custom field to it, you should be fine. I am not sure how to get the custom field on the report though, may be there is a plugin out there which does that.

1 2 3 (1-25/59)