Code Review Plugin 0.2.7 Released.

Added by Haruyuki Iida about 5 years ago

Code Review Plugin 0.2.7 Released.
If you use Redmine 0.8.7, you must upgrade to 0.2.7.

http://r-labs.googlecode.com/files/redmine_code_review-0.2.7.zip

Features:

  • Compatible with Redmine 0.8.7
  • Now code review dialog is resizable.
  • Added link to preview.
  • Compatible with development mode(experimental)

Regards.

Replies (103)

RE: Code Review Plugin 0.2.7 Released. - Added by Andy Bolstridge almost 4 years ago

I loved this plugin, but now I have to un-install it (it conflicts with the patch for multiple repositories #779), and I don't seem to be able to!

does anyone have any suggestions: I've tried 'rake db:migrate-plugins PLUGIN=redmine_code_review VERSION=0' as described by Jean-Phillippe and it does nothing. I've tried a few variations on this too, still nothing.

Before I try hacking it out by deleting directories and sql tables, has anyone else achieved this 'properly'?

thanks. (and yes, I may try to patch this to work with the multi-repo issue, but I have to have a site working without error 500 sections first)

RE: Code Review Plugin 0.2.7 Released. - Added by Andy Bolstridge almost 4 years ago

forget my last post, I found it out:

rake db:migrate:plugin NAME=redmine_code_review VERSION=0

RE: Code Review Plugin 0.2.7 Released. - Added by Natan Yellin almost 4 years ago

Redmine crashes when I try to create a new project. I am running Redmine 1.0.

(And thank you for the amazing plugin.)

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida almost 4 years ago

Natan Yellin wrote:

Redmine crashes when I try to create a new project. I am running Redmine 1.0.

I have released a new version 0.4.0. Please try this one.
https://bitbucket.org/haru_iida/redmine_code_review/downloads

RE: Code Review Plugin 0.2.7 Released. - Added by Natan Yellin almost 4 years ago

Now I get an error when I try to view projects:

@A ActionView::TemplateError occurred in projects#show:

Mysql::Error: Table 'nyellin_redmine.code_review_project_settings' doesn't exist: SELECT * FROM `code_review_project_settings` WHERE (project_id = 4)  LIMIT 1
On line #48 of app/views/layouts/base.rhtml
45:
46: <% if display_main_menu?(project) %>
47: <div id="main-menu">
48: <%= render_main_menu(@project) %>
49: </div>
50: <% end %>
51: </div>

RE: Code Review Plugin 0.2.7 Released. - Added by Natan Yellin almost 4 years ago

Never mind. I ran the migration wrong. :/

RE: Code Review Plugin 0.2.7 Released. - Added by Terence Mill almost 4 years ago

Bug Report: Clicking/opening Linked Tasks directly results in "access denied"

I i click the Link for Issue id in the upper right corner on the code review popup editor or try to surf to the task ticket url directly entering the url into the browsxwer, i get an "access denied" error.

RE: Code Review Plugin 0.2.7 Released. - Added by Natan Yellin almost 4 years ago

Update to latest version.

RE: Code Review Plugin 0.2.7 Released. - Added by Terence Mill almost 4 years ago

Is that bug fixed in latest version?
Terence Mill wrote:

Bug Report: Clicking/opening Linked Tasks directly results in "access denied"

I i click the Link for Issue id in the upper right corner on the code review popup editor or try to surf to the task ticket url directly entering the url into the browsxwer, i get an "access denied" error.

RE: Code Review Plugin 0.2.7 Released. - Added by Holger Waldmann almost 4 years ago

Haru Iida wrote:

I have released a new version 0.4.0. Please try this one.

Thanks for this magnificent plugin.

Is there any form of documentation regarding the configuration?
I do not fully understand what the different settings are for.
Especialy the two different tracker selections.
Thanks.

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida almost 4 years ago

Terence Mill wrote:

Is that bug fixed in latest version?

Yes. I fixed it.

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida almost 4 years ago

Holger Waldmann wrote:

Haru Iida wrote:

I have released a new version 0.4.0. Please try this one.

Thanks for this magnificent plugin.

Is there any form of documentation regarding the configuration?

Sorry, there isn't any document about configuration.
I want someone to write English document about this plugin. Because my English is quite terrible:p

I do not fully understand what the different settings are for.
Especialy the two different tracker selections.
Thanks.

First one is for the code reviews.
And second one is for review requests. You can assign someone for code review.

RE: Code Review Plugin 0.2.7 Released. - Added by Holger Waldmann almost 4 years ago

Haru Iida wrote:

Holger Waldmann wrote:

Is there any form of documentation regarding the configuration?

Sorry, there isn't any document about configuration.
I want someone to write English document about this plugin. Because my English is quite terrible:p

I will write a documentation if someone explains (even in terrible english :-) ) how it is meant to work.
I do know how hard it is to speak or write using a foreign language.

I do think that three parts will be needed:
1. Install, upgrade and uninstall (for an admin who has no knowledge about ruby and rails)
2. Configuration of the code review plugin
3. Explanation of intended workflow and the interaction between tickets and code reviews

RE: Code Review Plugin 0.2.7 Released. - Added by Loan Quynh almost 4 years ago

1. I'm used redmine 1.04 and install your plugin: code review 0.4.1
2. Can you tell me detail main step for configuration of the code review plugin? because i have error when when i click on number of line in file example 1 or 2...

NoMethodError in Code_review#update_attachment_view
Showing vendor/plugins/redmine_code_review/app/views/code_review/_update_diff_view.html.erb where line #36 raised:

undefined method `code_review_assignments' for #<Attachment:0x3071282c>
Extracted source (around line #36):

33: change_id = @change.id if @change
34: assignments = @change.code_review_assignments if @change
35: attachment_id = @attachment.id if @attachment
36: assignments = @attachment.code_review_assignments if @attachment
37: ->
38:
39: <
= show_assignments assignments, @project, {:action_type => @action_type, :rev => @rev, :rev_to => @rev_to, :path => @path, :change_id => change_id, :attachment_id => attachment_id} -%>

P/s: i review in file was uploaded with issues , i don't used repository.

error.PNG (23.3 KB)

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida almost 4 years ago

Hi Loan Quynh

I think your redmine runs on development mode.
This plugin works only on production mode.

Thanks.

RE: Code Review Plugin 0.2.7 Released. - Added by Ivan Cenov almost 4 years ago

@Loan Quynh: Where did you download CodeReview 0.4.1 from? Isn't 0.4.0 the last released version?

RE: Code Review Plugin 0.2.7 Released. - Added by imarion arion almost 4 years ago

How can I uninstall Code Review Plugin 0.3.0 from Redmine 0.9.3?
http://magnetdownloads.com/

RE: Code Review Plugin 0.2.7 Released. - Added by Andy Bolstridge almost 4 years ago

this works for me to uninstall any plugin.

rake db:migrate:plugin NAME=[your plugin name (as in vendor/plugins directory)] VERSION=0

RE: Code Review Plugin - Added by Kristijan Horvat over 3 years ago

Hi,

I don't know if this is obsolete board or not (if so please point the right way), can anyone tell me if review comments create a new issue in the project or notify the code owner in any way ?

Regards

RE: Code Review Plugin 0.2.7 Released. - Added by Ivan Cenov over 3 years ago

Hi,

You are asking whether comments in a code review issue creates new issue, aren't you?
Well, the code review issues are normal issues created by the code review plugin. They conform to notification policy that is applied for all the issues.

RE: Code Review Plugin 0.2.7 Released. - Added by Kristijan Horvat over 3 years ago

Yes, I was curious about the comments left by the plugin, I need to install the plugin and see how it works.

Thanks.

RE: Code Review Plugin 0.2.7 Released. - Added by Ivan Cenov over 3 years ago

Kristijan Horvat wrote:

Yes, I was curious about the comments left by the plugin, I need to install the plugin and see how it works.

Thanks.

Aha, the comments are the same as in other issues.

Code Review Plugin 0.4.5 - Added by Jonas J almost 3 years ago

The plugin 0.4.5 of redmine_code_review works well!

Thank you for this plugin!

I tested it with:

RedMine 1.2.1
Hudson/Jenkins plugin 1.0.7

---
Link to plugin:
https://bitbucket.org/haru_iida/redmine_code_review/downloads

RE: Code Review Plugin 0.2.7 Released. - Added by Akos Maroy over 2 years ago

can't seem to be able to install this plugin:

# rake db:migrate_plugins RAILS_ENV=production
Jeweler, or one of its dependencies, is not available. Install it with: sudo gem install technicalpickles-jeweler -s http://gems.github.com
rake aborted!
Don't know how to build task 'db:migrate_plugins'

(See full trace by running task with --trace)
# gem install technicalpickles-jeweler -s http://gems.github.comFetching: git-1.2.5.gem (100%)
Fetching: rubyforge-2.0.4.gem (100%)
Fetching: technicalpickles-jeweler-1.2.1.gem (100%)
ERROR:  While executing gem ... (TypeError)
    can't dup NilClass

this is on redmine 1.3.0 and ruby 1.8

RE: Code Review Plugin 0.2.7 Released. - Added by Haruyuki Iida over 2 years ago

if you had executed rake in a directory 'redmine_code_review', this error occured.
Try again in root directory of redmine.

1 2 3 4 5 (76-100/103)