Project

General

Profile

Actions

Patch #10069

closed

delimiter improvments

Added by Peter Kalvin about 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email receiving
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

hi guys,

I have two suggestions for the email delimiter setting, which I think should be improved:

1. It should accept regex expression, because some email clients like web gmail will attach the signature after the quoted reply text, so it won't be cropped.

2. If not regexp, then it should not match the whole delimiter line, only the beginning of it. Here is a patch for that:

Index: app/models/mail_handler.rb
===================================================================
--- app/models/mail_handler.rb    (revision 8414)
+++ app/models/mail_handler.rb    (working copy)
@@ -378,7 +378,8 @@
   def cleanup_body(body)
     delimiters = Setting.mail_handler_body_delimiters.to_s.split(/[\r\n]+/).reject(&:blank?).map {|s| Regexp.escape(s)}
     unless delimiters.empty?
-      regex = Regexp.new("^[> ]*(#{ delimiters.join('|') })\s*[\r\n].*", Regexp::MULTILINE)
+      regex = Regexp.new("^[> ]*(#{ delimiters.join('|') }).*", Regexp::MULTILINE)
       body = body.gsub(regex, '')
     end
     body.strip

What do you guys think?


Related issues

Is duplicate of Redmine - Feature #5864: Regex Text on Receiver EmailClosedJean-Philippe Lang2010-07-10

Actions
Actions #1

Updated by Filou Centrinov almost 11 years ago

Category: Email reveiving

Actions #2

Updated by Toshi MARUYAMA almost 11 years ago

  • Category set to Email receiving
Actions #3

Updated by Go MAEDA over 7 years ago

  • Is duplicate of Feature #5864: Regex Text on Receiver Email added
Actions #4

Updated by Go MAEDA over 7 years ago

  • Status changed from New to Closed

Regular expression delimiter has been implemented by #5864.
It will be available in upcoming Redmine 3.4.0.

Actions #5

Updated by Toshi MARUYAMA about 7 years ago

  • Description updated (diff)
Actions

Also available in: Atom PDF