Defect #10115

Javascript error - Can't attach more than 1 file on IE 6 and 7

Added by Hong Choi almost 6 years ago. Updated almost 6 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Attachments
Target version:1.3.1
Resolution:Fixed Affected version:1.3.0

Description

Users can't add new attachment form due to Javascript error on IE 6 and 7.

It seems there's mis-use of the Prototype.js at redmine's application.js

On addFileField() method, "document.createElement()" method must be replaced with "new Element()".

function addFileField() {
  //...
  //var s = document.createElement("span"); // This should be changed as
  var s = new Element("span");
  //...
}

Associated revisions

Revision 8780
Added by Jean-Philippe Lang almost 6 years ago

Fixed: Can't attach more than 1 file on IE 6 and 7 (#10115).

Revision 8781
Added by Jean-Philippe Lang almost 6 years ago

Merged r8780 from trunk (#10115).

History

#1 Updated by Etienne Massip almost 6 years ago

  • Resolution set to Wont fix

Sorry but IE6 or IE7 are pretty old browsers right now, so this issue is unlikely to be fixed some day.

#2 Updated by Jean-Philippe Lang almost 6 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 1.3.1
  • Resolution changed from Wont fix to Fixed

It's a simple change, so it's worth to be committed.

#3 Updated by Jean-Philippe Lang almost 6 years ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF