https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-04-24T12:57:15ZRedmineRedmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=24142008-04-24T12:57:15ZVijay Kiran
<ul><li><strong>File</strong> <a href="/attachments/444">help_menu_in_new_window.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/444/help_menu_in_new_window.txt">help_menu_in_new_window.txt</a> added</li></ul><p>I'm not sure if this the rightway to do it. But this patch works for me.</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=24292008-04-24T21:58:11ZJon Morrow
<ul></ul><p>Will take a look at this later today! Thanks!!!</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=24302008-04-24T22:09:38ZJon Morrow
<ul></ul><p>Me like thanks!</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=581672014-08-19T04:06:01ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/13263">Feature #13263</a>: Prevent confusion generated by the top Help link</i> added</li></ul> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1072682022-07-11T15:10:57ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/29431">1069.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29431/1069.patch">1069.patch</a> added</li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>I think also "Powered by Redmine" link in the footer should open a new tab. Attaching a patch.</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1072692022-07-11T17:01:33ZHolger Just
<ul></ul><p>Just adding <code>target="_blank"</code> potentially allows the target of the link to interact with the original site which opened the link via the <code>window.opener</code> property to e.g. load a new page there, resulting in the thread of phishing, credential stealing or worse.</p>
<p>This can be circumvented by adding <code>rel="noopener"</code> to these links. While most modern browsers now implicitly set this for any such links, <a href="https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility" class="external">some do not yet</a>. As such, it is still a safer option to explicitly set this too. In your patch, you can set this with</p>
<pre><code class="ruby syntaxhl"><span class="o">...</span> <span class="ss">:target</span> <span class="o">=></span> <span class="s1">'_blank'</span><span class="p">,</span> <span class="n">rel</span> <span class="o">=></span> <span class="s1">'noopener'</span> <span class="o">...</span>
</pre>
<p>See <a class="external" href="https://mathiasbynens.github.io/rel-noopener/">https://mathiasbynens.github.io/rel-noopener/</a> for a description of the original issue and its workarounds.</p></code></pre> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1072712022-07-11T22:14:19ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/29432">1069-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29432/1069-v2.patch">1069-v2.patch</a> added</li></ul><p>Holger Just wrote:</p>
<blockquote>
<p>This can be circumvented by adding <code>rel="noopener"</code> to these links.</p>
</blockquote>
<p>Updated the patch. Thank you for pointing it out.</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1072752022-07-12T11:09:39ZHolger Just
<ul></ul><p>Looks good to me!</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1073372022-07-18T02:13:54ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.1.0</i></li></ul><p>Setting the target version to 5.1.0.</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1074172022-07-22T01:34:17ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>"Help" link should launch new page.</i> to <i>Open Help in a separate tab</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p> Redmine - Feature #1069: Open Help in a separate tabhttps://www.redmine.org/issues/1069?journal_id=1112642023-10-29T22:49:15ZMischa The Evil
<ul><li><strong>Start date</strong> deleted (<del><i>2008-04-15</i></del>)</li></ul>