Patch #10916

Optimisation in issues relations display

Added by Jérôme BATAILLE over 5 years ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:2.3.0

Description

In the relations loop some variables are recalculated too many times

app_views_issues_relations.rhtml_2012-05-14.diff Magnifier (2.31 KB) Jérôme BATAILLE, 2012-05-14 18:23

Associated revisions

Revision 11121
Added by Jean-Philippe Lang almost 5 years ago

Store the other issue in a variable (#10916).

History

#1 Updated by Jean-Baptiste Barth over 5 years ago

Setting.blah is already cached in an Setting's class variable. The other optimization might be relevant, it would save some == calls and conditions..

#2 Updated by Jérôme BATAILLE almost 5 years ago

Do you want us to bring a new patch taking in accound your remark ?

#3 Updated by Jean-Philippe Lang almost 5 years ago

  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Target version set to 2.3.0

Variable named other_issue added to store relation.other_issue(@issue) as proposed in the patch, thanks.

#4 Updated by Jérôme BATAILLE 8 months ago

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

#5 Updated by Toshi MARUYAMA 7 months ago

Jérôme BATAILLE wrote:

Hi, you can indicate in the Resolution that's it's Fixed, if you have the time to, thanks a lot.

"patch" tracker does not have "resolution" filed.

Also available in: Atom PDF