Defect #11

Minor rendering problem within Safari at admin/mail_options...

Added by Chris Grant over 10 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Resolution: Affected version:

Description

In views/admin/mail_options.rhtml :

Added a self-clearing DIV so that fieldset border actually contains the checkboxes:

Original:
<% actions.keys.sort.each do |group_id| >
<fieldset style="margin-top: 6px;"><legend><strong><
= l(Permission::GROUPS[group_id])
></strong></legend>
<
actions[group_id].each do |p| >
<div style="width:170px;float:left;"><
= check_box_tag "action_ids[]", p.id, p.mail_enabled?
>
<
= l(p.description.to_sym) >
</div>
<
end >
</fieldset>
<
end %>

Changed:
<% actions.keys.sort.each do |group_id| >
<fieldset style="margin-top: 6px;"><legend><strong><
= l(Permission::GROUPS[group_id])
></strong></legend>
<
actions[group_id].each do |p| >
<div style="width:170px;float:left;"><
= check_box_tag "action_ids[]", p.id, p.mail_enabled?
>
<
= l(p.description.to_sym) >
</div>
<
end >
<div style="clear: both;"></div>
</fieldset>
<
end %>

It's the simple <div style="clear: both"></div> that's been added.

It's a small thing. ;) Thanks for this cool, cool project!

mail_options.rhtml Magnifier (765 Bytes) Chris Grant, 2008-02-03 10:48

_form.rhtml Magnifier (729 Bytes) Chris Grant, 2008-02-03 10:48

History

#1 Updated by Jean-Philippe Lang over 10 years ago

thanks, i've committed the fix in the repository.

#2 Updated by Chris Grant over 10 years ago

I've made the appropriate change in views/roles/_form.rhtml and
uploaded the
fixed file. Sorry for not knowing how to submit a formal patch
-- will have to
look into how to do that. Thanks again for this project, it's
great!

#3 Updated by Chris Grant over 10 years ago

This problem is present within the role permissions screen, as
well. I looked
around to find if there were similar problems and I guess I missed
this screen.
You can add the self-clearing DIV to that layout, as well.

#4 Updated by Jean-Philippe Lang over 10 years ago

Thanks for your submission.
Do you have the same problem on the role permissions screen ?
because it's the same kind of layout.

Regards,
Jean-Philippe

Also available in: Atom PDF