Defect #11209: Wiki diff may generate broken HTML - Redmine

Actions

Copy link

Defect #11209

closed

Wiki diff may generate broken HTML

Added by Kouhei Sutou almost 12 years ago. Updated almost 12 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Wiki

Target version:

2.0.4

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

2.0.3

Description

If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:

<div class="text-diff">
h1. CookBook documentation 
<br /> Some updated [[documentation]] here... <span class="diff_in">
<br /> More contents...&lt;/span&gt;
</div>

Close </span> tag is escaped.

For example:

Before

h1. CookBook documentation
Some updated [[documentation]] here...

After:

h1. CookBook documentation
Some updated [[documentation]] here...
More contents...

"More contents..." line is added. This case, diff page generates broken HTML.

Files

0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch (3.91 KB) 0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch

Kouhei Sutou, 2012-06-20 17:30

Related issues

Actions

Copy link

Updated by Kouhei Sutou almost 12 years ago

File 0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch 0001-Fix-too-escaped-span-in-diff-page-for-Wiki-11209.patch added

I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.

Actions

Copy link

Updated by Jean-Philippe Lang almost 12 years ago

Status changed from New to Confirmed

Actions

Copy link

Updated by Jean-Philippe Lang almost 12 years ago

Subject changed from diff page for Wiki may generate broken HTML to Wiki diff may generate broken HTML
Status changed from Confirmed to Resolved
Assignee set to Jean-Philippe Lang
Target version set to 2.0.4
Resolution set to Fixed