Revision graph sometimes broken due to raphael.js error
|Assignee:||Jean-Philippe Lang||% Done:|
In most Git repositories here, the revision graph is sometimes not completely rendered, some (or even most) lines and dots are missing. I tried it in FF 14 and Safari 6 with the same result.
Firefox error console shows this:
Since revision_graph.js does not use any of the deprecated API of Raphaël 2.1, I tried updating Raphaël:
This completely fixes the problem.
#1 Updated by Daniel Ritz 9 months ago
Spoke too soon. Found another case where things are not drawn. Turns out the problem is the missing "space" property of some of the commits. I'll check the root case later. Meanwhile the quick fix in revision_graph.js is this:
#6 Updated by Etienne Massip 8 months ago
Jean-Philippe Lang wrote:
The space property is supposed to be numeric so setting it to 0 if it's undefined can't be bad.
IIRC it means forcing the position of the commit on the first displayed branch which is not necessarily correct, that's all my concern.
As Daniel says, having this property unset probably hides some deeper cause.