Project

General

Profile

Actions

Defect #11966

closed

404 Error when switching mode in view revision differences in non-main repo

Added by Alexander Altynchurin over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When I try switch view mode in Revision/View differences window for non-main repo, I get 404 error.

I found that repo id is not included in URL after changing the view differences mode.


Related issues

Related to Redmine - Defect #11982: SCM diff view generates extra parameter for switching modeClosedToshi MARUYAMA

Actions
Actions #1

Updated by Alexander Altynchurin over 11 years ago

Probably there is an error in /app/views/repositiories/diff.html.erb in line 4

<% form_tag({:path => to_path_param(@path)}, :method => 'get') do %>
Actions #2

Updated by Toshi MARUYAMA over 11 years ago

  • Status changed from New to Confirmed
  • Affected version (unused) changed from 1.4.0 to 1.4.4
  • Affected version changed from 1.4.0 to 1.4.4
Actions #3

Updated by Toshi MARUYAMA over 11 years ago

  • Priority changed from Normal to Low

I confirmed 1.4-stable has this bug.
And trunk r10487 has no bug.

route.rb has changed heavily from Rails2 to Rails3.
Fix the bug of only 1.4-stable is a high cost.

Actions #4

Updated by Alexander Altynchurin over 11 years ago

Associated code changes solve the problem, thank you!

Actions #5

Updated by Toshi MARUYAMA over 11 years ago

  • Target version set to 1.4.5
  • Resolution set to Fixed
Actions #6

Updated by Toshi MARUYAMA over 11 years ago

  • Status changed from Confirmed to Resolved
  • Resolution deleted (Fixed)
Actions #7

Updated by Toshi MARUYAMA over 11 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Merged in 1.4-stable.

Actions

Also available in: Atom PDF