Defect #11966

404 Error when switching mode in view revision differences in non-main repo

Added by Alexander Altynchurin about 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:1.4.5
Resolution:Fixed Affected version:1.4.4

Description

When I try switch view mode in Revision/View differences window for non-main repo, I get 404 error.

I found that repo id is not included in URL after changing the view differences mode.


Related issues

Related to Redmine - Defect #11982: SCM diff view generates extra parameter for switching mode Closed

Associated revisions

Revision 10490
Added by Toshi MARUYAMA about 5 years ago

explicitly define route at scm diff view (#11966)

Revision 10502
Added by Toshi MARUYAMA about 5 years ago

add functional test of main repository diff path (#11966)

Revision 10503
Added by Toshi MARUYAMA about 5 years ago

add functional test of sub repository diff path (#11966)

Revision 10506
Added by Toshi MARUYAMA about 5 years ago

Merged r10490 from trunk to 1.4-stable (#11966)

explicitly define route at scm diff view.

Revision 10507
Added by Toshi MARUYAMA about 5 years ago

Merged r10502 from trunk to 1.4-stable (#11966)

add functional test of main repository diff path.

Revision 10508
Added by Toshi MARUYAMA about 5 years ago

Merged r10503 from trunk to 1.4-stable (#11966)

add functional test of sub repository diff path.

Revision 10509
Added by Toshi MARUYAMA about 5 years ago

Merged r10490 from trunk to 2.1-stable (#11982, #11966)

explicitly define route at scm diff view.

Revision 10510
Added by Toshi MARUYAMA about 5 years ago

Merged r10502 from trunk to 2.1-stable (#11982, #11966)

add functional test of main repository diff path.

Revision 10511
Added by Toshi MARUYAMA about 5 years ago

Merged r10503 from trunk to 2.1-stable (#11982, #11966)

add functional test of sub repository diff path.

History

#1 Updated by Alexander Altynchurin about 5 years ago

Probably there is an error in /app/views/repositiories/diff.html.erb in line 4

<% form_tag({:path => to_path_param(@path)}, :method => 'get') do %>

#2 Updated by Toshi MARUYAMA about 5 years ago

  • Status changed from New to Confirmed
  • Affected version (unused) changed from 1.4.0 to 1.4.4
  • Affected version changed from 1.4.0 to 1.4.4

#3 Updated by Toshi MARUYAMA about 5 years ago

  • Priority changed from Normal to Low

I confirmed 1.4-stable has this bug.
And trunk r10487 has no bug.

route.rb has changed heavily from Rails2 to Rails3.
Fix the bug of only 1.4-stable is a high cost.

#4 Updated by Alexander Altynchurin about 5 years ago

Associated code changes solve the problem, thank you!

#5 Updated by Toshi MARUYAMA about 5 years ago

  • Target version set to 1.4.5
  • Resolution set to Fixed

#6 Updated by Toshi MARUYAMA about 5 years ago

  • Status changed from Confirmed to Resolved
  • Resolution deleted (Fixed)

#7 Updated by Toshi MARUYAMA about 5 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Merged in 1.4-stable.

Also available in: Atom PDF