Defect #12138

Plain Text Emails are Html Escaped

Added by Wyatt Barnett about 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Resolution:Duplicate Affected version:2.0.4

Description

We are running redmine 2.0.4 in the following environment:

About your application's environment
Ruby version              1.8.7 (x86_64-linux)
RubyGems version          1.8.15
Rack version              1.4
Rails version             3.2.6
Active Record version     3.2.6
Action Pack version       3.2.6
Active Resource version   3.2.6
Action Mailer version     3.2.6
Active Support version    3.2.6
Middleware                Rack::Cache, ActionDispatch::Static, Rack::Lock, #<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x7f933e927768>, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::RemoteIp, ActionDispatch::Callbacks, ActiveRecord::ConnectionAdapters::ConnectionManagement, ActiveRecord::QueryCache, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, ActionDispatch::ParamsParser, ActionDispatch::Head, Rack::ConditionalGet, Rack::ETag, ActionDispatch::BestStandardsSupport, OpenIdAuthentication
Application root          /webapps/ncta-redmine/data/redmine
Environment               production
Database adapter          mysql
Database schema version   20120422150750

We recently upgraded to this from a very wonky redmine 1.2 setup. Most of our users actually just interface through email, but we've noticed that the new version is automatically html escaping everything.

I think the fix is to modify the templates to add .html_safe where appropriate to the text templates. But there might be a more elegant way as I can't claim to know much ruby nor rails.

Anyhow, please advise if there is a better way, I'm happy to submit a patch if not.


Related issues

Duplicates Redmine - Defect #11355: Plain text notification emails content is HTML escaped Closed

History

#1 Updated by Etienne Massip about 5 years ago

  • Status changed from New to Closed
  • Resolution set to Duplicate

This has been fixed with #11355 for 2.1.0.

#2 Updated by Wyatt Barnett about 5 years ago

Thanks, my redmine-search-fu failed me.

Also available in: Atom PDF