Patch #1218

Patch for relative links to icon images in 'public/help/wiki_syntax.html'

Added by Hajime Baba over 9 years ago. Updated about 9 years ago.

Status:ClosedStart date:2008-05-09
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:0.7.3

Description

Hi, forks,

I suppose that relative links to icon images
in 'public/help/wiki_syntax.html'
should be '../images/jstoolbar/bt_strong.png',
not '../../images/jstoolbar/bt_strong.png'.

If Redmine is deployed on such as mongrel or webrick,
there seems to be no problem, because the links traverse
to the root directory so that the absolute paths are converted
to '/images/jstoolbar/bt_strong.png'.

However, the links are broken when I have deployed Redmine
to a sub URI on Phusion Passenger (mod_rails) with Apache
configuration 'RailsBaseURI /redmine'. About this setting, see
http://www.modrails.com/documentation/Users%20guide.html#deploying_to_sub_uri
for more details.

Below is a simple patch. Thank you for your consideration.

Best Regards,
Hajime BABA

wiki_syntax.html.diff Magnifier (5.46 KB) Hajime Baba, 2008-05-09 16:30

Associated revisions

Revision 1609
Added by Jean-Philippe Lang about 9 years ago

Fixes relative paths to images in wiki_syntax.html (#1218).

History

#1 Updated by Marc Liyanage about 9 years ago

I just noted the same issue and would really appreciate the inclusion of this patch in the next version...

#2 Updated by Jean-Philippe Lang about 9 years ago

  • Category changed from Documents to UI
  • Status changed from New to Closed
  • Target version set to 0.8

You're absolutely right.
Patch committed in r1609. Thanks.

#3 Updated by Jean-Philippe Lang about 9 years ago

  • Target version changed from 0.8 to 0.7.3

Also available in: Atom PDF