https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-11-11T09:36:35ZRedmineRedmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=55312008-11-11T09:36:35ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> deleted (<del><i>0.8</i></del>)</li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=93552009-05-18T15:59:49ZDaniel Jones
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=167412010-05-14T21:50:39ZRoyce Williams
<ul></ul><p>+1. Empowering users to modify their own request can reduce the load on the people processing requests.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=195292010-08-19T04:45:25ZАлексей Лошкарёв
<ul></ul><p>+1 This may reduce count of misspelled or invalid bug. Because user may do mistake on filling bug.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=211412010-10-08T03:41:02ZLeo Hourvitz
<ul><li><strong>File</strong> <a href="/attachments/4632">0001-Added-edit_own_issues-and-edit_own_new_issues-permis.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4632/0001-Added-edit_own_issues-and-edit_own_new_issues-permis.patch">0001-Added-edit_own_issues-and-edit_own_new_issues-permis.patch</a> added</li></ul><p>I have a patch for this against recent trunk, attached. We are having this problem in a big way at an installation of mostly native Japanese speakers; with Asian languages, you're always hitting return to do Kanji conversion of your input and one extra carriage return means a half-baked issue in the tracker!</p>
<a name="New-Permissions"></a>
<h2 >New Permissions<a href="#New-Permissions" class="wiki-anchor">¶</a></h2>
I addressed this by creating two new permissions that can be assigned to roles:
<ul>
<li>edit_own_issues allows users with that permission to edit issues they created (i.e., whose author field is equal to the current user). This addresses the problem, but is potentially a big workflow change, so not all sites might want it. </li>
<li>edit_own_new_issues is a more limited permission that allows a user to edit their own issues if there are no journals yet, or if all existing journals were created by the author. I think this is really the pinpoint solution to the problem; as far as I know, all edits will create a journal, so this lets you edit your issue until the moment someone else pays attention to it.
<ul>
<li>Because it seems like such a contained right, in the patch I added it to the default permissions for the Reporter role.</li>
</ul></li>
</ul>
<a name="Implementation"></a>
<h2 >Implementation<a href="#Implementation" class="wiki-anchor">¶</a></h2>
<p>To implement the above, I created a new editable? predicate on the issue model parallel to the visible? predicate that was already there (this also seems like a pretty good pattern to follow in general). Then, I changed the code that was doing<br /><code> User.current.allowed_to?(:edit_issues, @project)</code><br />to just call<br /><code> issue.editable?</code><br />instead.</p>
<p>I updated the English and Japanese locales as well.</p>
<p>The patch file was formatted with git format-patch; is that the preferred patch format? Specifically, the patch was generated against svn+ssh://rubyforge.org/var/svn/redmine/trunk@4175 e93f8b46-1217.</p>
<p>I'm fairly new to Redmine and Ruby, so it would definitely be good to get other eyes on this patch. I'll be able to get in some more testing next week. My configuration is:</p>
<pre>
bash-3.2$ RAILS_ENV=production ruby script/about
About your application's environment
Ruby version 1.8.7 (universal-darwin10.0)
RubyGems version 1.3.5
Rack version 1.0
Rails version 2.3.5
Active Record version 2.3.5
Active Resource version 2.3.5
Action Mailer version 2.3.5
Active Support version 2.3.5
Application root /Users/leo/OpenSrcSources/redmine
Environment production
Database adapter mysql
Database schema version 20100819172912
</pre> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=213532010-10-13T15:08:32ZLeo Hourvitz
<ul></ul><p>I also applied this patch on our production redmine at work (Redmine 1.0.1 release on CentOS 5.2).</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=225442010-11-19T01:43:57ZNathan Eggen
<ul></ul><p>+1 - this should go in the trunk.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=242702011-01-19T09:13:54ZBernhard Furtmueller
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=244722011-01-25T18:45:13ZBrian Lindahl
<ul></ul><p>Created patch issue to follow the progression of my patch to add this feature and other issue edit permission improvements. Please add relation to <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Patch for improved issue edit permissions (Closed)" href="https://www.redmine.org/issues/7444">#7444</a>.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=248112011-02-04T02:42:04ZLeo Hourvitz
<ul></ul><p>Is there any approved way to urge this get moved to trunk? I need to apply this on every Redmine instance we use, I think any installation with real scale of users is unmanageable without something like this.</p>
<p>Brian: I don't seem to have permissions to add the relation.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=249772011-02-08T18:54:14ZBrian Lindahl
<ul></ul><p>Leo: Issue relations in Redmine are controlled by a different permission: 'Manage issue relations'. I can see a situation where project managers/software leads would not want issue reporters to have the ability to set up relations. Perhaps another permission should be added: 'Manage own issue relations'?</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=249782011-02-08T18:58:37ZBrian Lindahl
<ul></ul><p>Leo: Hah! Just realized that you were saying that you don't have the permissions to relate this issue to my patch issue <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Patch for improved issue edit permissions (Closed)" href="https://www.redmine.org/issues/7444">#7444</a>.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=307102011-07-13T17:05:12ZEtienne Massip
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=351802012-01-05T16:13:24ZGokay Gok
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=353742012-01-14T17:45:06ZAleksej Lebedev
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=362322012-02-22T08:50:09ZYannick Recht
<ul></ul><p>+1 also.</p>
<p>It should be interesting to add this parameter.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=391312012-06-18T21:28:44ZGabriel Mazetto
<ul></ul><p>It's also wise to have a "time limit" to help people not trying to modify something made a year ago, for example. As we will never find a good for everyone value, it's good to have it configurable, some values as suggestion:</p>
<ul>
<li>Limit own issue editing and own issue comments:
<ul>
<li>Custom (please specify)</li>
<li>30 days</li>
<li>15 days</li>
<li>7 days</li>
<li>3 days</li>
<li>24 hours</li>
<li>12 hours</li>
<li>6 hours</li>
<li>3 hours</li>
<li>less then one hour</li>
<li>Never</li>
</ul></li>
</ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=410222012-09-19T08:46:08ZRolf Bagge
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=410772012-09-20T16:57:19ZBruno Passos
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=429892012-11-21T16:44:44ZThierry Brochu
<ul></ul><p>This would be an excellent feature to allow our client to edit the mistakes on its own created issues without having us to deal with it through a note left on this same issue by him. +1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=429942012-11-21T20:19:47ZTerence Mill
<ul></ul><p>+1 - very useful for redmine.org itself</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=520942013-09-26T20:44:13ZAnonymous
<ul></ul><p>+1 crucial</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=543912014-01-20T08:23:09ZFlorian Kaiser
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=556052014-03-31T13:13:24ZAlain V.
<ul></ul><p>+1 please for 3.0.0</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=578432014-08-03T06:00:05ZAlain V.
<ul></ul><p>A feature that we should have, please!</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=578482014-08-03T07:24:22ZEtienne Massip
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/6194">Feature #6194</a>: Edit own issues</i> added</li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=583632014-09-01T03:33:11ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/5195">Feature #5195</a>: edit_own_issues and delete_own_issues permissions</i> added</li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=601292014-12-01T12:21:19ZAlain V.
<ul></ul><p>+1 please</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=616432015-02-20T07:17:02ZOleg Aksenov
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=616542015-02-20T20:35:26ZOmer Arslan
<ul></ul><p>+1 - will be very useful</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=620812015-03-09T15:44:30ZGuillaume Laneel
<ul></ul><p>+1 will be usefull</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=620822015-03-09T15:48:25ZSandro De Melis
<ul></ul><p>+1 this would be an excellent feature</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=632622015-04-21T16:31:47Z4wk_ _
<ul></ul><p>+1, really need this. "Editing issue" grant ppl to be like an admin ! (and we don't want that, we want "Edit own issue")</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=636782015-05-13T05:41:19ZChet Wang
<ul></ul><p>+100</p>
<p>I really need this feature. We're planning to use Redmine but the lack of this feature blocks a lot.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=641262015-06-11T08:31:35ZDo Lam
<ul></ul><p>+100. We need this permission. <br />Thank so much!</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=649102015-07-17T17:55:34ZAlexander Lyzhenkov
<ul></ul><p>+100 v 3.1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=651122015-07-27T10:11:53ZTrurl McByte
<ul></ul><p>+100500 It's bad idea to give access to edit all issues for Reporter only for possibility to change Status from Resolved to Closed</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=670602015-11-03T19:33:51ZAdnan Topçu
<ul></ul><p>Leo Hourvitz's <strong>edit_own_new_issues</strong> is good idea.<br /><strong>edit_own_issues</strong> is topic of this issue.<br /><strong>edit assigned issues</strong> is most important for me</p>
<p>In my opinion, "own" is not clear for this mean. Reported or created is more understable ?</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=670612015-11-03T19:40:56Zbudo kaiman
<ul></ul><p>+1 to separate "Edit Reported Issues" and "Edit Assigned Issues".</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=670622015-11-03T21:04:38ZRonie Henrich
<ul></ul><p>Adnan Topçu wrote:</p>
<blockquote>
<p>Leo Hourvitz's <strong>edit_own_new_issues</strong> is good idea.<br /><strong>edit_own_issues</strong> is topic of this issue.<br /><strong>edit assigned issues</strong> is most important for me</p>
<p>In my opinion, "own" is not clear for this mean. Reported or created is more understable ?</p>
</blockquote>
<p>Owner == Author all accross Redmine, modifying this Redmine convention is out of this issue's scope.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=670632015-11-03T21:20:49ZRonie Henrich
<ul></ul><p>budo kaiman wrote:</p>
<blockquote>
<p>+1 to separate "Edit Reported Issues" and "Edit Assigned Issues".</p>
</blockquote>
<ul>
<li>In regards to "Edit Reported Issues", please read my comment 40 (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: New Permission: Edit own issues (Closed)" href="https://www.redmine.org/issues/1248#note-40">#1248#note-40</a>) above;</li>
<li>If a user belongs to a role with "Issues can be assigned to this role" enabled, having something like "Edit Assigned Issues" is not gonna stop him/her to edit an issue, it is just a matter of assigning the issue to himself/herself and <em>voila</em>, now he/she may edit the issue.</li>
</ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=670722015-11-04T12:10:14Zbudo kaiman
<ul></ul><p>Ronie Henrich wrote:</p>
<blockquote>
<ul>
<li>If a user belongs to a role with "Issues can be assigned to this role" enabled, having something like "Edit Assigned Issues" is not gonna stop him/her to edit an issue, it is just a matter of assigning the issue to himself/herself and <em>voila</em>, now he/she may edit the issue.</li>
</ul>
</blockquote>
<p>That only works if they already have "Edit Issues" permission, if they don't have that permission then they cannot assign an issue to themself, someone else with that permission must assign the issue to them.</p>
<p>Ronie Henrich wrote:</p>
<blockquote>
<p>Owner == Author all accross Redmine, modifying this Redmine convention is out of this issue's scope.</p>
</blockquote>
<p>I don't think that there is any scope change, just a wording change as "Author" or "Reporter" is more clear in it's intention.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=737462016-09-24T11:49:59ZYuuki NARA
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=754462016-12-28T20:34:42ZPasi Karkkainen
<ul></ul><p>Yes please, this is an important feature to have!</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=763432017-01-27T22:08:54ZJosé Campos
<ul></ul><p>+1</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=814312017-10-06T04:35:21ZEugene Belford
<ul></ul><p>must have feature indeed</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=883182018-11-08T14:28:27ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/29935">Feature #29935</a>: Edit authored issues and Edit assigned issues in issue tracking permission</i> added</li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=897502019-02-03T05:17:00ZGo MAEDA
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/4767">Feature #4767</a>: Add permission group to allow 'edit your own tickets (header)'.</i> added</li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=903202019-02-20T01:58:09ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/22456">add_permit_edit_own_issues@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22456/add_permit_edit_own_issues@2x.png">add_permit_edit_own_issues@2x.png</a> added</li><li><strong>File</strong> <a href="/attachments/22457">1248-edit-own-issues-permit.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22457/1248-edit-own-issues-permit.patch">1248-edit-own-issues-permit.patch</a> added</li></ul><p>Added "Edit own issues" permission. This permission can edit issues created by you regardless of the presence or absence of a journal.<br />I attached a patch.</p>
<p><img src="https://www.redmine.org/attachments/download/22456/add_permit_edit_own_issues@2x.png" srcset="https://www.redmine.org/attachments/download/22456/add_permit_edit_own_issues@2x.png 2x" style="width:50%;border:1px solid #ccc;" alt="" /></p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=913172019-04-23T15:40:48ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>LGTM. Setting the target version to 4.1.0.</p> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=913382019-04-25T05:34:43ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Permissions - Edit own issues</i> to <i>New Permission: Edit own issues</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul> Redmine - Feature #1248: New Permission: Edit own issueshttps://www.redmine.org/issues/1248?journal_id=1113752023-11-01T22:17:50ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-9 priority-4 priority-default" href="/issues/39493">Defect #39493</a>: Role with only :edit_own_issues no longer considered for workflow</i> added</li></ul>