Project

General

Profile

Actions

Patch #12611

closed

Login link unexpected logs you out

Added by Andrew Dahl over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Category:
Accounts / authentication
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

If you log in and then revisit the /login page, Redmine currently logs you out and requires you to log back in. I believe this is unexpected behavior, as if you do this on most websites, you're redirected as though you just logged in.

The patch attached fixes this issue explained.

Redmine 2.1.4.stable
Ruby 1.9.3
Rails 3.2.8

This issue is similar to #11847 ;however, has nothing to do with back_url and is solving the bigger problem, I think.


Files


Related issues

Related to Redmine - Patch #11847: Autologin if have back_urlClosed

Actions
Actions #1

Updated by Jean-Philippe Lang over 11 years ago

  • Tracker changed from Defect to Patch
Actions #2

Updated by Etienne Massip over 11 years ago

  • Target version set to Candidate for next minor release

Agreed, should logout only on /logout or new login.

Actions #3

Updated by Jean-Philippe Lang over 11 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 2.3.0

Patch committed in r11122 with a test.

Actions #4

Updated by Bruno Medeiros over 11 years ago

Does this patch redirects to the back_url param if it exists? As far as I could understand, it doesn't, and I think it should, it will be a great improvement! This problem always annoyed me, good to see it's fixed!

Actions

Also available in: Atom PDF