Patch #12611

Login link unexpected logs you out

Added by Andrew Dahl almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Accounts / authentication
Target version:2.3.0

Description

If you log in and then revisit the /login page, Redmine currently logs you out and requires you to log back in. I believe this is unexpected behavior, as if you do this on most websites, you're redirected as though you just logged in.

The patch attached fixes this issue explained.

Redmine 2.1.4.stable
Ruby 1.9.3
Rails 3.2.8

This issue is similar to #11847 ;however, has nothing to do with back_url and is solving the bigger problem, I think.

redmine-login_unexpectedly_logs_you_out_fix-DrewDahl.patch Magnifier (1.13 KB) Andrew Dahl, 2012-12-16 23:59


Related issues

Related to Redmine - Patch #11847: Autologin if have back_url Closed

Associated revisions

Revision 11122
Added by Jean-Philippe Lang almost 5 years ago

Login link unexpected logs you out (#12611).

History

#1 Updated by Jean-Philippe Lang almost 5 years ago

  • Tracker changed from Defect to Patch

#2 Updated by Etienne Massip almost 5 years ago

  • Target version set to Candidate for next minor release

Agreed, should logout only on /logout or new login.

#3 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 2.3.0

Patch committed in r11122 with a test.

#4 Updated by Bruno Medeiros almost 5 years ago

Does this patch redirects to the back_url param if it exists? As far as I could understand, it doesn't, and I think it should, it will be a great improvement! This problem always annoyed me, good to see it's fixed!

Also available in: Atom PDF