Defect #13335

Autologin does not work with custom autologin cookie name

Added by Alik E over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Accounts / authentication
Target version:2.3.0
Resolution:Fixed Affected version:2.2.3

Description

It appears that Redmine has two problems with autologin:
1. It does not work with OpenID. This is discussed in #3371.
2. If you set custom autologin_cookie_name, autologin does not work, since the code that checks for that cookie still assumes default name (:autologin)

Attached patch fixes both of those issues - hopefully ;-)

autologin.patch Magnifier (2.8 KB) Alik E, 2013-03-02 08:08

Associated revisions

Revision 11519
Added by Jean-Philippe Lang over 4 years ago

Fixed that autologin is broken when using a custom cookie name (#13335).

Revision 11520
Added by Jean-Philippe Lang over 4 years ago

Fixed that autologin cookie is not deleted when using custom cookie name (#13335).

Revision 11569
Added by Jean-Philippe Lang over 4 years ago

Merged r11519 and r11520 from trunk (#13335).

History

#1 Updated by Jean-Philippe Lang over 4 years ago

  • Subject changed from Autologin patch (fixes OpenID and custom autologin cookie name) to Autologin does not work with custom autologin cookie name
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.3.0
  • Resolution set to Fixed

Fixed in r11520, thanks for pointing this out.

#2 Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF