Defect #13348

Repository tree can't handle two loading at once

Added by Vadim Pushtaev over 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:2.3.4
Resolution:Fixed Affected version:

Description

On the Repository page I click [+] near the trunk folder and while loading is processing I click [+] near branches. After both loadings are finished I have this:

branches
|-branch1
|-branch2
|-file1
`-file2
tags
trunk

instead of this:
branches
|-branch1
`-branch2
tags
trunk
|-file1
`-file2

As you can see, loading result appeared in the last chosen folder, not in the appropriate one.

13348.diff Magnifier (658 Bytes) Vadim Pushtaev, 2013-11-13 10:05

Associated revisions

Revision 12274
Added by Toshi MARUYAMA about 4 years ago

fix repository tree can't handle two loading at once (#13348)

Contributed by Vadim Pushtaev.

Revision 12275
Added by Toshi MARUYAMA about 4 years ago

Merged r12274 from trunk to 2.3-stable (#13348)

fix repository tree can't handle two loading at once.

Contributed by Vadim Pushtaev.

Revision 12276
Added by Toshi MARUYAMA about 4 years ago

Merged r12274 from trunk to 2.4-stable (#13348)

fix repository tree can't handle two loading at once.

Contributed by Vadim Pushtaev.

History

#1 Updated by Toshi MARUYAMA over 4 years ago

  • Category set to SCM

#2 Updated by Vadim Pushtaev about 4 years ago

  • File 13348.diffMagnifier added
  • Status changed from New to Resolved

Looks like we just use global variable instead of local one:

 function scmEntryClick(id, url) {
-    el = $('#'+id);
+    var el = $('#'+id);
     if (el.hasClass('open')) {
         collapseScmEntry(id);
         el.addClass('collapsed');

Patch included.

#3 Updated by Toshi MARUYAMA about 4 years ago

  • Target version set to 2.4.0

#4 Updated by Toshi MARUYAMA about 4 years ago

  • Target version changed from 2.4.0 to 2.3.4

#5 Updated by Toshi MARUYAMA about 4 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Committed in trunk r12274, 2.3-stable r12275 and 2.4-stable r12276, thanks.

Also available in: Atom PDF