Defect #13405

Commit link title is escaped twice when using "commit:" prefix

Added by Etienne Massip over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:-% Done:

100%

Category:SCM
Target version:2.3.1
Resolution:Fixed Affected version:2.2.0

Description

r11510 revision link title is correctly displayed1.

commit:<not applicable here but imagine a commit id> revision link title is HTML escaped twice2.

1 source:/trunk/app/helpers/application_helper.rb@11510#L682.

2 source:/trunk/app/helpers/application_helper.rb@11510#L761.

Associated revisions

Revision 11671
Added by Etienne Massip over 4 years ago

Fixed commit link title escaping (fixes #13405).

Revision 11672
Added by Toshi MARUYAMA over 4 years ago

fix test failure (#13405)

  1) Failure:
test_scan_changesets_for_issue_ids(RepositoryTest) [/xxx/test/unit/repository_test.rb:214]:
<"Applied in changeset r2."> expected but was
<"Applied in changeset commit:691322a8eb01e11fd7.">.

Revision 11674
Added by Toshi MARUYAMA over 4 years ago

fix unit search test failure (#13405)

Revision 11678
Added by Toshi MARUYAMA over 4 years ago

Merged r11671, r11672 and r11674 from trunk to 2.3-stable (#13405)

Fixed commit link title escaping.

History

#1 Updated by Etienne Massip over 4 years ago

  • Status changed from Confirmed to Resolved
  • Target version changed from Candidate for next minor release to 2.3.1
  • Affected version (unused) changed from devel to 2.2.0
  • Resolution set to Fixed
  • Affected version set to 2.2.0

Should be fixed with r11671.

#2 Updated by Etienne Massip over 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

Applied in changeset r11671.

#3 Updated by Etienne Massip over 4 years ago

  • Status changed from Closed to Resolved

God damn it, the fixes keyword closes the issue.

Still to be merged...

#4 Updated by Toshi MARUYAMA over 4 years ago

  • Status changed from Resolved to Closed

Fixed tests on trunk and merged to 2.3-stable.

#5 Updated by Etienne Massip over 4 years ago

Thanks Toshi, saw the build failure after switching off my computer.

Also available in: Atom PDF