Patch #13612

Members roles : display group of role

Added by Jérôme BATAILLE about 4 years ago. Updated 5 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Groups
Target version:Candidate for next minor release

RM_13612_members_roles_-_display_group_of_role_RM_V1.2.1.diff Magnifier (2.99 KB) Jérôme BATAILLE, 2013-03-27 14:30

group_roles.png (48.7 KB) Jérôme BATAILLE, 2013-03-27 17:56

RM_13612_members_roles_-_display_group_of_role_RM_V1.2.1.diff Magnifier - RM V2.5+ (2.03 KB) Jérôme BATAILLE, 2014-11-05 11:45

RM_13612_members_roles_-_display_group_of_role_RM_V1.2.1.diff Magnifier - RM V2.5+ (1.85 KB) Jérôme BATAILLE, 2014-11-05 16:15

rm13612-note_7_patch_against_trunk_r16111.patch Magnifier (1.52 KB) Mischa The Evil, 2016-12-27 04:52

user-belongs-to-two-group.png (10.1 KB) Go MAEDA, 2017-01-09 08:51


Related issues

Related to Redmine - Defect #6301: Unintuitive display of groups in project settings New 2010-09-05

History

#1 Updated by Jérôme BATAILLE about 4 years ago

This patch was done on an old Redmine V1.2.1.

#2 Updated by Jérôme BATAILLE about 4 years ago

Example :

#3 Updated by Jan Niggemann (redmine.org team member) about 4 years ago

  • Target version set to Candidate for next minor release

#4 Updated by Jérôme BATAILLE over 2 years ago

Hi, this patch is simple to validate, is there is a chance that it could be integrated to V3.0.0 ?

#5 Updated by Jérôme BATAILLE over 2 years ago

Here is a patch against a more recent version of Redmine

#6 Updated by Jean-Philippe Lang over 2 years ago

Can you explain what a group of role is ? That would help to understand the purpose of the patch.

#7 Updated by Jérôme BATAILLE over 2 years ago

Hi Jean-Philippe,

I mean Group of the role, if the user is member of the project through a Group.

In the example image CDP is member of the project through the group Test2

The aim of this enhancement is to display this information, which is very be useful when you have a lot of users ands groups in the project

P.S. : the obsolete part is un-related, my mistake, here is a fixed fixed patch, you can remove the previous one.

#8 Updated by Jérôme BATAILLE about 1 year ago

Hi, I think this patch is interesting for cases where Group members are mixed with normal members.

Can you check it again ?

#9 Updated by Jérôme BATAILLE about 1 year ago

perhaps we can change the label :

User (by Group : <group name>)

#10 Updated by Go MAEDA 5 months ago

Jérôme BATAILLE wrote:

Can you check it again ?

The file RM_13612_members_roles_-_display_group_of_role_RM_V1.2.1.diff is a patch for vendor/plugins/redmine_smile/app/views/projects/settings/_members.rhtml.

Is it a patch for Redmine core? It looks like a patch for some plugin.

#11 Updated by Mischa The Evil 5 months ago

Go MAEDA wrote:

Jérôme BATAILLE wrote:

Can you check it again ?

The file RM_13612_members_roles_-_display_group_of_role_RM_V1.2.1.diff is a patch for vendor/plugins/redmine_smile/app/views/projects/settings/_members.rhtml.

Is it a patch for Redmine core? It looks like a patch for some plugin.

As far as I can tell it's a patch to the core's /projects/settings/_members.rhtml partial inside a Redmine plugin (redmine_smile), thus overloading the core's partial with the modified one. With that in mind I created a patch file against current trunk (r16111) which I hereby attach. Please note that I haven't tested any of this code, it's just a copy-paste of the patch in note 7 (which at maximum is against r4719) against current trunk. I quickly scanned the code and think that it should be working at current Redmine codebase though.

#12 Updated by Jérôme BATAILLE 5 months ago

Thanks to have generated the patch against current core.

This is a view only enhancement, with code that could be added in the controller. This patch has been on our production for a few years now and it's really useful.

#13 Updated by Go MAEDA 5 months ago

I tried out the patch and found a small problem. Please see the following screenshot. The user "User Misc" actually belongs to 2 groups ("A Team" and "B Team"), but only "A Team" is displayed on the right side of user name.

#14 Updated by Go MAEDA 4 months ago

  • Related to Defect #6301: Unintuitive display of groups in project settings added

Also available in: Atom PDF