Patch #14068

Increase base height of author lines on 'Commits per author' graph

Added by Mischa The Evil over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-

Description

In r11723 for #13486 the height of "Commits per author" graph is made flexible. This is done by taking a base height for each author (15) and multiplying that with the number of authors.

The current base height value seems to be a bit on the low side which makes the graph pretty difficult to read. I'll add some examples further on.

I tried several values and came to the conclusion that a value of 301 is working best for me. What do you think?

Examples
Repo Base height 15 Base height 30
Redmine rm_15.png (Redmine repo graph with base height of 15) rm_30.png (Redmine repo graph with base height of 30)
Apache httpd httpd_15.png (Apache httpd repo graph with base height of 15) httpd_30.png (Apache httpd repo graph with base height of 30)

1 in source:/trunk/app/controllers/repositories_controller.rb@11845#L414:

Index: app/controllers/repositories_controller.rb
===================================================================
--- app/controllers/repositories_controller.rb  (revision 11845)
+++ app/controllers/repositories_controller.rb  (working copy)
@@ -411,7 +411,7 @@
     fields = fields.collect {|c| c.gsub(%r{<.+@.+>}, '') }

     graph = SVG::Graph::BarHorizontal.new(
-      :height => 15 * commits_data.length,
+      :height => 30 * commits_data.length,
       :width => 800,
       :fields => fields,
       :stack => :side,

rm_15.png (Redmine repo graph with base height of 15) - Redmine repo graph with base height of 15 (7.1 KB) Mischa The Evil, 2013-05-16 02:39

rm_30.png (Redmine repo graph with base height of 30) - Redmine repo graph with base height of 30 (11.2 KB) Mischa The Evil, 2013-05-16 02:39

httpd_15.png (Apache httpd repo graph with base height of 15) - Apache httpd repo graph with base height of 15 (15.4 KB) Mischa The Evil, 2013-05-16 02:40

httpd_30.png (Apache httpd repo graph with base height of 30) - Apache httpd repo graph with base height of 30 (25.3 KB) Mischa The Evil, 2013-05-16 02:40


Related issues

Related to Redmine - Defect #1983: statistics get rather cramped with more than 15 or so con... Closed 2008-10-03

Associated revisions

Revision 11847
Added by Toshi MARUYAMA over 4 years ago

increase base height of author lines on 'Commits per author' graph (#14068, #1983)

Contributed by Mischa The Evil.

History

#1 Updated by Toshi MARUYAMA over 4 years ago

  • Tracker changed from Feature to Patch
  • Status changed from New to Closed

I committed r11847 which changes from 15 to 30, thanks.

Also available in: Atom PDF