CVS root_url not recognized when connection string does not include port
|Assignee:||Jean-Philippe Lang||% Done:|
The patch fixes a bug in the CVS SCM module of the standard version of redmine (2.3.1).
Without this bugfix, the revisions are not handled correctly. Each revision-number (e.g. 1.4) is only accepted once by the redmine repository, although each file has its own revision-numbers.
In our case the CVSROOT looks like this:
The problem is located in \lib\redmine\scm\adapters\cvs_adapter.rb in the method root_url_path
--> RegExp was changed from
This lets the property return the correct part of the CVSROOT-URL
("/repo" instead of ":email@example.com:9876/repo")
And now the function 'fetch_changesets' works as expected with CVS.
Find attached the patch file.
#4 Updated by Dominik Follmann almost 5 years ago
Sorry, I was wrong in my description and copy-pasted the wrong CVSROOT. This happened, because I already put wrong comments to my source code when I implemented the patch some weeks ago ;-)
What I meant was:
So without the explicit port after the IP-Address.
So the correct test would be:
def test_root_url_path adapter = Redmine::Scm::Adapters::CvsAdapter.new('foo', ':pserver:cvs_user:firstname.lastname@example.org/repo') assert_equal '/repo', adapter.send(:root_url_path) end
#5 Updated by Jean-Philippe Lang almost 5 years ago
- Tracker changed from Patch to Defect
- Subject changed from Improvement for CVS-Adapter to handle CVSROOT correct to CVS root_url not recognized when connection string does not include port
- Status changed from Needs feedback to Resolved
- Assignee set to Jean-Philippe Lang
- Target version changed from 2.4.0 to 2.3.3
- Resolution set to Fixed
The proposed patch matches an IP adress only. It won't work if a host name is used.
A different fix is committed in r12027, thanks for pointing this out.