Defect #14798

Wrong done_ratio calculation for parent with subtask having estimated_hours=0

Added by Daniel Felix about 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues planning
Target version:2.3.3
Resolution:Fixed Affected version:

Description

Hi there,

this patch corrects a bug in the calculation of the done_ratio value in some edge case.

Ways to reproduce this bug:
  • Define a parent issue
  • Define two subissues on this parent issue
  • Set on one subissue estimated_hours to 0
  • Close subissue with no estimated_hours -> parent issue has done_ratio = 50%
  • Close subissue with estimated_hours set to zero value -> parent issue still has done_ratio = 50%

This patch solves this issue.

@Jean-Philippe: Maybe you or Toshi could take a look at this?

Best regards,
Daniel

patch_done_ratio_on_zero_values.diff Magnifier (805 Bytes) Daniel Felix, 2013-08-29 10:13

Associated revisions

Revision 12131
Added by Jean-Philippe Lang about 4 years ago

Wrong done_ratio calculation for parent with subtask having estimated_hours=0 ().

Patch by Daniel Felix.

History

#1 Updated by Felix Schäfer about 4 years ago

We also stumbled on this at Planio, the proposed diff fixes the problem, thanks!

#2 Updated by Jean-Philippe Lang about 4 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from Wrong done_ratio calculation on zero values in subissue. to Wrong done_ratio calculation for parent with subtask having estimated_hours=0
  • Status changed from New to Resolved
  • Target version set to 2.3.3
  • Resolution set to Fixed

Patch committed with a test, thanks for pointing this out.

#3 Updated by Jean-Philippe Lang about 4 years ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF