Project

General

Profile

Actions

Defect #14881

closed

Issue journals should be ordered by created_on, not id

Added by Felix Schäfer over 10 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

r10547 changes the ordering of journals in IssuesController#show from created_on ASC do id ASC, is there a specific reason for this? Ordering by ID is probably right in most cases, we have a Jira import where this is not the case.


Related issues

Has duplicate Redmine - Defect #17852: Issue journals should be ordered by created_on, not idClosed

Actions
Has duplicate Redmine - Patch #18440: Journals could be ordered using the create_on attribute instead of the idClosed

Actions
Actions #1

Updated by Jean-Philippe Lang over 10 years ago

This was changed because journals may have the same created_on value. We could use created_on ASC, id ASC instead to fix your issue but importing journals in chronological order would have been a better option :/

Actions #2

Updated by Felix Schäfer over 10 years ago

Ah, because of the split public changes/private notes journals? I understand.

created_on ASC, id ASC would work, thanks!

Actions #3

Updated by Toshi MARUYAMA over 10 years ago

  • Category set to Issues
Actions #4

Updated by Go MAEDA over 9 years ago

  • Has duplicate Defect #17852: Issue journals should be ordered by created_on, not id added
Actions #5

Updated by Go MAEDA over 9 years ago

  • Related to Patch #18440: Journals could be ordered using the create_on attribute instead of the id added
Actions #6

Updated by Go MAEDA over 9 years ago

  • Related to deleted (Patch #18440: Journals could be ordered using the create_on attribute instead of the id)
Actions #7

Updated by Go MAEDA over 9 years ago

  • Has duplicate Patch #18440: Journals could be ordered using the create_on attribute instead of the id added
Actions #8

Updated by Toshi MARUYAMA almost 9 years ago

#61 note order is strange.
#61#note-5 is oldest.

#61#note-5 -> #61#note-4 -> #61#note-3 -> #61#note-2 -> #61#note-1 ->
#61#note-6 -> #61#note-7 ...

Actions #9

Updated by Jean-Philippe Lang almost 9 years ago

  • Subject changed from Issue comments in wrong order to Issue journals should be ordered by created_on, not id
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.1.0
  • Resolution set to Fixed
Actions

Also available in: Atom PDF