Defect #15113

The mail method should return a Mail::Message

Added by Florian Schwab about 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Florian Schwab% Done:

0%

Category:Code cleanup/refactoring
Target version:2.4.0
Resolution:Fixed Affected version:

Description

The overwritten mail method (ActionMailer::Base) in source:trunk/app/models/mailer.rb should return a Mail object instead of a symbol (the locale set/returned by set_language_if_valid) to be compliant with the original mail method.

mailer_return_value.patch Magnifier (1021 Bytes) Florian Schwab, 2013-10-12 14:11

Associated revisions

Revision 12210
Added by Jean-Philippe Lang about 4 years ago

Fixed that the mail method should return a Mail::Message (#15113).

History

#1 Updated by Jean-Philippe Lang about 4 years ago

  • Subject changed from The mail method should return a object of type Mail to The mail method should return a Mail::Message
  • Category set to Code cleanup/refactoring
  • Status changed from New to Closed
  • Assignee set to Florian Schwab
  • Target version set to 2.4.0
  • Resolution set to Fixed

The patch broke a test. I've fixed it and added a test in r12210, thanks.

Also available in: Atom PDF