https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292013-11-10T15:05:00ZRedmineRedmine - Feature #15311: Add an indication to admin/info whether or not ImageMagick convert is availablehttps://www.redmine.org/issues/15311?journal_id=530542013-11-10T15:05:00ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/10737">rm15311-add_convert_availability_indication-trunk_r12240.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10737/rm15311-add_convert_availability_indication-trunk_r12240.diff">rm15311-add_convert_availability_indication-trunk_r12240.diff</a> added</li><li><strong>File</strong> <a href="/attachments/10738">rm15311-add_convert_availability_indication.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10738/rm15311-add_convert_availability_indication.png">rm15311-add_convert_availability_indication.png</a> added</li></ul><p>Patch, including English and Dutch translations (EN stubs for others) attached. A test for this tiny change is omitted.</p>
<p>The essence of the patch:<br /><pre><code class="diff syntaxhl"><span class="gh">Index: app/controllers/admin_controller.rb
===================================================================
</span><span class="gd">--- app/controllers/admin_controller.rb (revision 12240)
</span><span class="gi">+++ app/controllers/admin_controller.rb (working copy)
</span><span class="p">@@ -77,7 +77,8 @@</span>
[:text_default_administrator_account_changed, User.default_admin_account_changed?],
[:text_file_repository_writable, File.writable?(Attachment.storage_path)],
[:text_plugin_assets_writable, File.writable?(Redmine::Plugin.public_directory)],
<span class="gd">- [:text_rmagick_available, Object.const_defined?(:Magick)]
</span><span class="gi">+ [:text_rmagick_available, Object.const_defined?(:Magick)],
+ [:text_convert_available, Redmine::Thumbnail.convert_available?]
</span> ]
end
end
</code></pre></p>
<p>This changes admin/info like:</p>
<p><a class="thumbnail" title="Thumbnail of rm15311-add_convert_availability_indication.png" href="https://www.redmine.org/attachments/10738"><img alt="rm15311-add_convert_availability_indication.png" src="https://www.redmine.org/attachments/thumbnail/10738/550" /></a></p> Redmine - Feature #15311: Add an indication to admin/info whether or not ImageMagick convert is availablehttps://www.redmine.org/issues/15311?journal_id=531602013-11-15T20:11:19ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> changed from <i>UI</i> to <i>Administration</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>2.4.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Thanks for patch, it's committed in <a class="changeset" title="Add an indication to admin/info whether or not ImageMagick convert is available (#15311). Patch ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/12278">r12278</a>.</p>