Defect #15485

HTML 5 validation multiple ids

Added by Ksenia Altbregen about 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:2.5.0
Resolution:Fixed Affected version:

Description

Related to #15191, r12236.

Everywhere I've found multiple check_box_tag calls, I've put :id => nil.

multiple_ids_vanilla.diff Magnifier (13.7 KB) Ksenia Altbregen, 2013-11-22 16:32

Associated revisions

Revision 12653
Added by Jean-Philippe Lang almost 5 years ago

Removes duplicate ids (#15485).

Revision 12654
Added by Jean-Philippe Lang almost 5 years ago

Removes duplicate ids (#15485).

Revision 12655
Added by Jean-Philippe Lang almost 5 years ago

Removes duplicate ids (#15485).

Revision 12656
Added by Jean-Philippe Lang almost 5 years ago

Removes duplicate ids (#15485).

Revision 12657
Added by Jean-Philippe Lang almost 5 years ago

Removes duplicate ids (#15485).

History

#1 Updated by Jean-Philippe Lang about 5 years ago

  • Status changed from New to Needs feedback

Most of the patch is OK but this patch also removes non-duplicate ids like in app/views/projects/_form.html.erb. It shouldn't.

#2 Updated by Jean-Philippe Lang almost 5 years ago

  • Tracker changed from Patch to Defect
  • Status changed from Needs feedback to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.5.0
  • Resolution set to Fixed

Actually, the patch contains lots of syntax errors. Now fixed.

Also available in: Atom PDF