Defect #16036

wiki edit pencil links are sometimes missing, throwing off the other pencil edit links

Added by Domingo Galdos over 3 years ago. Updated 4 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Wiki
Target version:-
Resolution: Affected version:

Description

This is similar to #11789 -- some sections have their pencil icon missing, but the count continues regardless. On a large page this sometimes happens many times which means that by the time you're halfway through the doc the pencils are basically useless. In fact the pencils have become mostly useless on our wiki due to this issue.

I observe it with h6, possibly with some others. Not sure of the exact pattern to it, but I am able to reliably reproduce it @ http://demo.redmine.org/projects/testproj1/wiki/Wiki/3 as well as on our own installation which uses the following (not that it's too relevant since it's easily reproducible on the redmine demo wiki which I assume is up to date)

Environment:
  Redmine version                2.4.1.stable
  Ruby version                   2.0.0-p353 (2013-11-22) [x86_64-linux]
  Rails version                  3.2.15
  Environment                    production
  Database adapter               Mysql2

Here's a copy of the repro text on the wiki link above in case it gets removed or something

h1. Wiki

hi

h2. h2

hi

h5. CI Nickname:

* Monitored 
* Notification 
* Notification G
* Checks

h6. Check
* CI 
* Interval 
* Submit
* Instance 
* Check

This means: every longer existing.

If the be sent.

h3. h3
hi 

h4. h4
hi 

Related issues

Related to Redmine - Defect #14188: Headers put inside blockquotes cause wiki 'edit this sect... Confirmed

History

#1 Updated by Jon Goldberg 4 months ago

I believe that at least one cause of this is if you have preformatted text that would normally get an "edit pencil".

E.g. (assuming Markdown text):

# Header 1 gets a pencil
```
# Here's a comment in a bash script.
...bash script here
```
# Header 2 gets a pencil, but it points to the comment in the bash script, because the pencil edits starting from the second hash mark.

#2 Updated by Mischa The Evil 4 months ago

  • Related to Defect #14188: Headers put inside blockquotes cause wiki 'edit this section' link point to incorrect section added

Also available in: Atom PDF