https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292014-05-02T23:51:03ZRedmineRedmine - Defect #16795: Member#destroy triggers after_destroy callbacks twicehttps://www.redmine.org/issues/16795?journal_id=561642014-05-02T23:51:03ZIslam Azab
<ul></ul><p><a class="external" href="https://github.com/redmine/redmine/blob/master/app/controllers/members_controller.rb">https://github.com/redmine/redmine/blob/master/app/controllers/members_controller.rb</a><br /><pre>
def destroy
if request.delete? && @member.deletable?
@member.destroy
end
respond_to do |format|
format.html { redirect_to_settings_in_projects }
format.js
format.api {
if @member.destroyed?
render_api_ok
else
head :unprocessable_entity
end
}
end
end
</pre></p>
<p><a class="external" href="https://github.com/redmine/redmine/blob/master/app/models/member_role.rb">https://github.com/redmine/redmine/blob/master/app/models/member_role.rb</a><br /><pre>
def remove_member_if_empty
if member.roles.empty?
member.destroy
end
end
</pre></p> Redmine - Defect #16795: Member#destroy triggers after_destroy callbacks twicehttps://www.redmine.org/issues/16795?journal_id=564662014-05-24T09:56:01ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>fixed member deletion to avoid dublicate after_destroy callbacks</i> to <i>Member#destroy triggers after_destroy callbacks twice</i></li><li><strong>Category</strong> set to <i>Code cleanup/refactoring</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> set to <i>2.5.2</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed in <a class="changeset" title="Fixed that Member#destroy triggers after_destroy callbacks twice (#16795)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13140">r13140</a>, thanks for pointing this out.</p> Redmine - Defect #16795: Member#destroy triggers after_destroy callbacks twicehttps://www.redmine.org/issues/16795?journal_id=564842014-05-24T16:37:48ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p>