Defect #1804

JRuby, Windows and RUBY_PLATFORM

Added by Babar O'Cap almost 4 years ago. Updated over 3 years ago.

Status:Closed Start date:2008-08-21
Priority:High Due date:
Assignee:- % Done:

0%
Category:SCM
Target version:0.8
Affected version:0.7.3 Resolution:Fixed

Description

Hi,
There is a bug with Redmine on JRuby (v.1.1.3) and Windows (XP SP2).
When i want to see my Subversion repository, there is an error.
#<REXML::ParseException: No close tag for ["lists", "list"]>
I've found the problem :
In this file REDMINE_ROOT\lib\redmine\scm\adapters\abstract_adapter.rb at line 141
if RUBY_PLATFORM =~ /mswin/
RUBY_PLATFORM return java the condition result is false but i'm under Windows!
And the generated svn command is
svn list --xml 'svn://hostname/svn_repos//'@HEAD
instead of
svn list --xml "svn://hostname/svn_repos//"@HEAD

Maybe that problem is in other files of Redmine.

PS: Sorry for my bad English, I'm French.

abstract_adapter.patch (734 Bytes) Magnifier Babar O'Cap, 2008-08-21 15:28

Associated revisions

Revision 1753
Added by Jean-Philippe Lang over 3 years ago

Fixes platform determination under JRuby (#1804).

History

#1 Updated by Jean-Philippe Lang over 3 years ago

  • Status changed from New to Closed
  • Affected version changed from devel to 0.7.3
  • Resolution set to Fixed

Fix committed in r1753 with slight changes and fixes in a few more files (method Redmine::Platform.mswin? added to avoid code duplication).
Thanks for pointing out.

Also available in: Atom PDF