Patch #18911

check Setting.protocol when determining gravatar protocol

Added by Maciej Liżewski almost 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Project settings
Target version:-

Description

proposed change is in line 1235 of app/helpers/application_helper.rb

instead:
options.merge!({:ssl => (request && request.ssl?), :default => Setting.gravatar_default})

change to:
options.merge!({:ssl => ((Setting.protocol == 'https') || (request && request.ssl?)), :default => Setting.gravatar_default})

without that when Redmine is behind reverse proxy that do SSL gravatar links are generated as http (when everywhere else is https as expected after Setting.protocol is changed to 'https')


Related issues

Related to Redmine - Defect #9365: Gravatar don't utilize HTTPS Closed 2011-10-03
Related to Redmine - Defect #21855: Gravatar get images over http instead https Closed

History

#1 Updated by Toshi MARUYAMA over 2 years ago

  • Related to Defect #9365: Gravatar don't utilize HTTPS added

#2 Updated by Toshi MARUYAMA over 2 years ago

  • Status changed from New to Needs feedback

Similar change was refused at #9365.

#3 Updated by Maciej Liżewski over 2 years ago

OK... That is also acceptable solution.
I did not know about it (using http header) and I did not find it when I was looking for solution - maybe resolution of this issue could be only updating docs to point that out? (somewhere near the description of Settings protocol flag).

BTW - what is the reason for having this "protocol" setting? Does Redmine use it only when generating email messages?

#4 Updated by Go MAEDA over 1 year ago

  • Related to Defect #21855: Gravatar get images over http instead https added

#5 Updated by Go MAEDA over 1 year ago

  • Status changed from Needs feedback to Closed

This issue have been resolved by #21855 (will be available as of Redmine 3.3.0).

Also available in: Atom PDF