Patch #1998

Raise project-identifier length-limit from 20 to 30 characters

Added by Mischa The Evil about 9 years ago. Updated almost 7 years ago.

Status:ClosedStart date:2008-10-07
Priority:NormalDue date:
Assignee:-% Done:

80%

Category:Projects
Target version:-

Description

I just add this patch more as a PoC showing how it could be done. I thought it might be usefull for some other users...

Note that this patch raises the maximum-length of a project-identifer from 20 characters to 30 characters. If the limit of 30 characters isn't sufficient modify the patch by replacing the instances of 30 (29 in some cases) to the desired maximum-length.

Note: this patch requires a migration. The migration-file is in Timestamped-style so it won't conflict with upstream but can be modified easily (when once needed). The used timestamp is: 20081007020300

Warning: this patch can malform/break URL's depending on your setup. I guess that is the main reason why project-identifiers are limited to 20 characters by default anyway.

raise_project_identifier_length_limit_to_30-r1926.diff Magnifier - Patch created against r1926 of the trunk. (2.28 KB) Mischa The Evil, 2008-10-07 02:16


Related issues

Blocks Redmine - Feature #6446: Remove length limits on project identifier and name Closed 2010-09-20

History

#1 Updated by Alexandre Garino about 9 years ago

Could you please increase the length to 60 characters as well (see #1789, #1893)?

#2 Updated by Szabolcs Szasz about 9 years ago

Yes, great, and please, if you are anyway at it, could you also do remove the arbitrary and unnecessary 3-char lower limits, too? (See #2003.) I'd prefer the absolute minimum, which is 1. (I'm no big fan of l'art pour l'art arbitrary restrictions.)

#3 Updated by Mischa The Evil about 9 years ago

Alexandre Garino wrote:

Could you please increase the length to 60 characters as well (see #1789, #1893)?

I'd suggest that you modify the patches #1789 & #1998 yourself like I say in both issues:

If the limit of 30 characters isn't sufficient modify the patch by replacing the instances of 30 (29 in some cases) to the desired maximum-length

This is to kiss: otherwise seperate patches for several lenght-limits (30, 40, 50 etc.) should be created. Just read the contents of the patch (through redmine?) to see where I made the changes to 30 (29) and replace them by 60 (59).

HTH...

#4 Updated by G N about 8 years ago

+1 for both
  • lowering the minimum identifier length to 1 and
  • increasing the maximum identifier length to a reasonable value

#5 Updated by Anthony Paul about 7 years ago

+1
I actually patch the code to increase the identifier and name length to 255. It would be nice to have this feature by default or at least via a setting option.

#6 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from New to Closed

See #6446.

Also available in: Atom PDF