https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-01-25T16:29:00ZRedmineRedmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=4702008-01-25T16:29:00ZWarren Harris
<ul></ul><p>Here's another one... seems like there's no reason the news<br />summary shouldn't also be textilized. (patch included)</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123052009-11-22T19:54:55ZMischa The Evil
<ul><li><strong>Category</strong> set to <i>Text formatting</i></li></ul><p>Just a bump on the issue. Plus is seems slightly related to issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Code syntax highlighting not working in Document page (Closed)" href="https://www.redmine.org/issues/3740">#3740</a>.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123062009-11-22T19:59:11ZMischa The Evil
<ul><li><strong>Subject</strong> changed from <i>another missing textilization</i> to <i>Textilization of Documents and News</i></li></ul><p>Changed subject only.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123072009-11-22T19:59:33ZMischa The Evil
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li></ul> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123082009-11-22T20:32:05ZMischa The Evil
<ul></ul><p>Warren Harris wrote:</p>
<blockquote>
<p>[...] When the description is shown under the documents/show<br />page, it is correctly textilized [...]</p>
</blockquote>
<p>Except that syntax-highlighting isn't working in that specific case: see issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Code syntax highlighting not working in Document page (Closed)" href="https://www.redmine.org/issues/3740">#3740</a>.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123092009-11-22T21:34:43ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/2805">textilize-document-description_r3084.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2805/textilize-document-description_r3084.patch">textilize-document-description_r3084.patch</a> added</li><li><strong>File</strong> <a href="/attachments/2806">textilize-news-summary_r3084.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2806/textilize-news-summary_r3084.patch">textilize-news-summary_r3084.patch</a> added</li><li><strong>File</strong> <a href="/attachments/2807">textilize-timelog-entry-comment_r3084.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2807/textilize-timelog-entry-comment_r3084.patch">textilize-timelog-entry-comment_r3084.patch</a> added</li><li><strong>Subject</strong> changed from <i>Textilization of Documents and News</i> to <i>Textilization of Documents, News and Timelog-entry comments</i></li></ul><p>I'll make a summary of several different changes regarding proposals to render content as being "textilized":</p>
<p>1. I'll start with the initial request: At the documents page (at <a class="external" href="http://host.domain.tld/projects/projectfoo/documents">http://host.domain.tld/projects/projectfoo/documents</a>) documents are listed with a preview of their descriptions. However, the descriptions are not textilized.<br />When the description is shown under the documents/show page (at <a class="external" href="http://host.domain.tld/documents/1">http://host.domain.tld/documents/1</a>), it is correctly textilized.</p>
<p>(patch; <a class="attachment" href="https://www.redmine.org/attachments/2805">textilize-document-description_r3084.patch</a>)</p>
<p>2. Lateron in the journal of this issue the textilisation of the news <strong>summary</strong> is also proposed and patched.</p>
<p>(patch; <a class="attachment" href="https://www.redmine.org/attachments/2806">textilize-news-summary_r3084.patch</a>)</p>
<p>3. I've now also merged issue <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Textilized timelog comments (Closed)" href="https://www.redmine.org/issues/221">#221</a> into this issue. It's basically a simple request to render the timelog-entry comments also textilized.</p>
<p>(patch; <a class="attachment" href="https://www.redmine.org/attachments/2807">textilize-timelog-entry-comment_r3084.patch</a>)</p>
<p>I've rebased all three patches against the latest trunk and attached them to this issue. I'll close/update issue <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Textilized timelog comments (Closed)" href="https://www.redmine.org/issues/221">#221</a> as being a (partial) duplicate of this issue (patch <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Textilized timelog comments (Closed)" href="https://www.redmine.org/issues/221">#221</a> does some more then what the issue's description says, which is only textilisation of the timelog-comment).</p>
<p>Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=123112009-11-22T22:26:10ZMischa The Evil
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>[...] several different changes regarding proposals to render content as being "textilized":</p>
<p>1. [...] (patch; <a class="attachment" href="https://www.redmine.org/attachments/2805">textilize-document-description_r3084.patch</a>) [...]</p>
<p>2. [...] (patch; <a class="attachment" href="https://www.redmine.org/attachments/2806">textilize-news-summary_r3084.patch</a> [...]</p>
<p>3. [...] (patch; <a class="attachment" href="https://www.redmine.org/attachments/2807">textilize-timelog-entry-comment_r3084.patch</a> [...]</p>
<p>[...]</p>
<p>Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?</p>
</blockquote>
<p>My personal proposal would be to only merge the patch for number 3. That one seems to provide the most useable UI-enhancement with a small change without any unwanted side-effects.<br />Number 2 seems to has a slight side-effect on the project-overview block and the news index view where trailing new-lines are added. Number 1 seems a good start considering related issue <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Code syntax highlighting not working in Document page (Closed)" href="https://www.redmine.org/issues/3740">#3740</a> but therefor also seems to have a higher severity when integrating it in the current state of Redmine (before 0.9 feature freeze).</p>
<p>NB: With all these patches there exists a chance that the users enter comments with markup which /could/ make the UI break. It should be handled with care. This might also be a good reason to decline all off the three patches...</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=152692010-03-18T20:02:13ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Text formatting on documents index added in <a class="changeset" title="Adds text formatting to documents index (#202)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/3602">r3602</a>.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=152962010-03-19T14:49:22ZGustavo Gama
<ul><li><strong>File</strong> <a href="/attachments/3409">long_and_textilized_time_entry_comments.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3409/long_and_textilized_time_entry_comments.patch">long_and_textilized_time_entry_comments.patch</a> added</li></ul><p>I'm attaching a improved (imho) version of Micha's third patch (the one that deals with time entry comments).</p>
<p>It 'textilizes' time entry comments <strong>and</strong> removes the length restriction. Also, the form text_fields to enter the time entries were replaced by text_areas's.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=303152011-06-27T15:19:15ZTerence Mill
<ul></ul><p>related with <a class="issue tracker-2 status-5 priority-4 priority-default closed behind-schedule" title="Feature: make project overview text input fully wiki input text enabled (Closed)" href="https://www.redmine.org/issues/8668">#8668</a> - missing WIki full textile for project overview</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=467112013-03-16T15:58:35ZIvan Cenov
<ul></ul><p>Terence Mill wrote:</p>
<blockquote>
<p>related with <a class="issue tracker-2 status-5 priority-4 priority-default closed behind-schedule" title="Feature: make project overview text input fully wiki input text enabled (Closed)" href="https://www.redmine.org/issues/8668">#8668</a> - missing WIki full textile for project overview</p>
</blockquote>
<p>Not missing on present day.</p>
<p>News are textilized<br />time entry comment are not textilized</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=467202013-03-17T04:09:53ZMischa The Evil
<ul></ul><p>Ivan Cenov wrote:</p>
<blockquote>
<p>Terence Mill wrote:</p>
<blockquote>
<p>related with <a class="issue tracker-2 status-5 priority-4 priority-default closed behind-schedule" title="Feature: make project overview text input fully wiki input text enabled (Closed)" href="https://www.redmine.org/issues/8668">#8668</a> - missing WIki full textile for project overview</p>
</blockquote>
<p>Not missing on present day.</p>
</blockquote>
<p>I've updated <a class="issue tracker-2 status-5 priority-4 priority-default closed behind-schedule" title="Feature: make project overview text input fully wiki input text enabled (Closed)" href="https://www.redmine.org/issues/8668">#8668</a> accordingly. Thanks for mentioning it.</p>
<p>Ivan Cenov wrote:</p>
<blockquote>
<p>News are textilized</p>
</blockquote>
<p>News items are indeed textilized, but not the news summary.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=482052013-04-10T07:34:31ZDipan Mehta
<ul></ul><p>+1. This is very useful.</p>
<p>When is this likely to be fully accomplished?</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=728832016-08-23T11:15:28ZJW Fuchs
<ul></ul><p>+1<br />Textilization in the above mentioned areas would be helpful.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=754652016-12-29T22:04:59ZMarius BÄ‚LTEANU
<ul><li><strong>File</strong> <a href="/attachments/17369">textilization_for_spent_time_comments.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17369/textilization_for_spent_time_comments.patch">textilization_for_spent_time_comments.patch</a> added</li></ul><p>The attached patch adds textilization to spent time comments also.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=771852017-03-08T20:44:42ZMarius BÄ‚LTEANU
<ul></ul><p>Having textilization support for spent time comments is quite useful. Please let me know if tests are required for my patch.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=819892017-11-08T13:23:08ZDipan Mehta
<ul></ul><p>The document and news already seems to have textilization support as it seems. Don't know since when though!</p>
<p>Can we also complete the last part as well?</p>
<p><strong>Second oldest unresolved issue by now.</strong></p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=1049502021-12-24T00:51:14ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Unplanned backlogs</i></li></ul> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=1068502022-06-01T07:05:20ZTakenori TAKAKItakenory@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/29257">textilization_for_spent_time_comments_with_test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29257/textilization_for_spent_time_comments_with_test.patch">textilization_for_spent_time_comments_with_test.patch</a> added</li></ul><p>+1 Textlization of the spent time comments would be very useful.<br />I confirmed that the patch posted by <a class="user active" href="https://www.redmine.org/users/27597">Marius Ionescu</a> in <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Textilization of Documents, News and Timelog-entry comments (New)" href="https://www.redmine.org/issues/202#note-15">#202#note-15</a> works with the latest version of trunk (<a class="changeset" title="Merged r21618 to trunk (#35892)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21619">r21619</a>).<br />I made a patch with a little bit refactoring and additional test code, and attache it.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=1101282023-05-29T13:45:26ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Unplanned backlogs</i> to <i>5.1.0</i></li></ul><p>Setting the target version to 5.1.</p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=1109212023-10-09T01:10:49ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/31051">clipboard-202310091009-lju9y.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/31051/clipboard-202310091009-lju9y.png">clipboard-202310091009-lju9y.png</a> added</li><li><strong>Target version</strong> changed from <i>5.1.0</i> to <i>6.0.0</i></li></ul><p>Takenori TAKAKI wrote in <a href="#note-19">#note-19</a>:</p>
<blockquote>
<p>+1 Textlization of the spent time comments would be very useful.<br />I confirmed that the patch posted by <a class="user active" href="https://www.redmine.org/users/27597">Marius Ionescu</a> in <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Textilization of Documents, News and Timelog-entry comments (New)" href="https://www.redmine.org/issues/202#note-15">#202#note-15</a> works with the latest version of trunk (<a class="changeset" title="Merged r21618 to trunk (#35892)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21619">r21619</a>).<br />I made a patch with a little bit refactoring and additional test code, and attache it.</p>
</blockquote>
<p>Thank you for updating the patch but I think the patch should not render Markdown/Textile also in the Spent time tab of an issue.</p>
<p><img src="https://www.redmine.org/attachments/download/31051/clipboard-202310091009-lju9y.png" alt="" /></p> Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentshttps://www.redmine.org/issues/202?journal_id=1109612023-10-12T05:07:04ZTakenori TAKAKItakenory@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/31066">textilization_for_spent_time_comments_with_test-fix-21.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/31066/textilization_for_spent_time_comments_with_test-fix-21.patch">textilization_for_spent_time_comments_with_test-fix-21.patch</a> added</li></ul><p>Go MAEDA wrote in <a href="#note-21">#note-21</a>:</p>
<blockquote>
<p>Thank you for updating the patch but I think the patch should not render Markdown/Textile also in the Spent time tab of an issue.</p>
</blockquote>
<p>Go Maeda, thanks for pointing that out <a href="#note-21">#note-21</a>.<br />I have made a patch that fixes the problem you pointed out.<br />Please try the attached patch.</p>