Feature #2048

Code Review Module

Added by Gabriel Moreira almost 10 years ago. Updated about 5 years ago.

Status:NewStart date:2008-10-18
Priority:NormalDue date:
Assignee:-% Done:

20%

Category:Plugin Request
Target version:-
Resolution:

Description

Create a integrated code review module like atlassian crucible, reviewboard, rietveld, mondrian etc...

changeset_journals_v1.diff Magnifier - against revsion 2824 (9.78 KB) Aaron Soules, 2009-07-21 02:53


Related issues

Related to Redmine - Feature #7747: Add capability to ask\accept\reject review of patches (fl... New 2011-03-01
Related to Redmine - Feature #1339: Comments on revisions New 2008-05-31
Duplicated by Redmine - Feature #469: Code Review/Approve workflow? Closed

History

#1 Updated by Lane Roathe almost 10 years ago

+1 - this would be a very good feature for those of us using Redmine for project planning/management vs simple bug tracking.

#2 Updated by Alexandre Garino almost 10 years ago

+1

#3 Updated by Philippe Lafoucrière almost 10 years ago

+1, agree with Lane

#4 Updated by Thomas Lecavelier almost 10 years ago

Should be a plugin, not a feature: redmine has to stay as lightweight as possible out of the box.

#5 Updated by Octavian Cacina almost 10 years ago

+1, A fist step: allow comments on Changesets, it would be a big improvement in this direction.

#6 Updated by Gabriel Moreira almost 10 years ago

I agree. Allow comments on Changesets is more simple to begin.

Review Board: OpenSource (
http://www.review-board.org/

Atlassian Crucible Commercial (Has more features then Review Board)
http://www.atlassian.com/software/crucible/screenshots/default.jsp

#7 Updated by Aaron Soules almost 10 years ago

Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.

#8 Updated by Oleg Lozinskij over 9 years ago

+1

#9 Updated by Silas Sewell over 9 years ago

+1

#10 Updated by Alexey Lapitksy over 9 years ago

+1

#11 Updated by Aaron Soules about 9 years ago

I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.

Please let me know what I can improve/fix, This is my first contribution to Redmine :)

I've attached my diff against r2824

#12 Updated by Aaron Soules about 9 years ago

hmm, didn't see that code review plugin... guess this issue got a little stale :) I still like the github interface better, which is what I was going for. Any thoughts? Should this code stay outside of Redmine Core?

#13 Updated by Anton Nepomnyaschih about 9 years ago

There is code review plugin for redmine. It looks great: http://www.redmine.org/boards/3/topics/5878

#14 Updated by Etienne Massip almost 7 years ago

  • Category set to Plugin Request

#15 Updated by Dipan Mehta over 5 years ago

You can use the Code Review plugin. It works very well and quite the perfect module.

#16 Updated by rm user about 5 years ago

Dipan Mehta wrote:

You can use the Code Review plugin. It works very well and quite the perfect module.

no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.

you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).

in other words: its not suitable for using in production environment.

i read a lot about gerrit/reviewboard might give it a try later.

Also available in: Atom PDF