Feature #2065

Commit graph should merge homonyms

Added by Thomas Lecavelier about 9 years ago. Updated over 3 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Jean-Baptiste Barth% Done:

80%

Category:SCMEstimated time:1.00 hour
Target version:-
Resolution:Wont fix

Description

When looking to "commits by authors" graph (Repository/Statistics), redmine don't merge bars with homonyms. In this redmine instance you can see my name appears twice.
I suppose it's due to the facts I'm using a git repository with multiple account, where I haven't put the same email address.

IMHO, Redmine should merge bars with homonyms.

redmine-merge-homonyms.patch Magnifier - Patch merging homonyms for app app/controllers/repositories_controller.rb (1.7 KB) Guillaume Ayoub, 2009-11-11 15:39

redmine-merge-homonyms-39c9727.patch Magnifier - Patch for revision 39c9727 (1.81 KB) Guillaume Ayoub, 2010-02-25 13:46


Related issues

Related to Redmine - Defect #13487: Honor committer => user mapping in repository statistics Closed

History

#1 Updated by Patrick Naubert almost 9 years ago

We have the same problem. We are also using Git with multiple accounts. Perhaps a regex search-and-replace capability at repo import/update could be done ?

#2 Updated by Guillaume Ayoub about 8 years ago

Here is a patch (for version 0.8.6) merging homonyms. I don’t know ruby very well and my syntax may be a little bit strange, but some ruby guru should clean these few lines easily.

Works with git, not tested with other version control systems.

#3 Updated by Ammler _ almost 8 years ago

I would like this feature quite much in too.

might it be possible to update to current heads of 0.9 and trunk?

#4 Updated by Guillaume Ayoub almost 8 years ago

Here is the previous patch updated for revision 39c9727 of git. As I said, this code works here with git, but it should be cleaned and tested with other version control systems.

#5 Updated by Ibrahim Awwal over 7 years ago

Is there any chance of this being integrated into a release sometime? I will have to try applying your patch when I get a chance.

#6 Updated by Ibrahim Awwal over 7 years ago

Ibrahim Awwal wrote:

Is there any chance of this being integrated into a release sometime? I will have to try applying your patch when I get a chance.

Ah, it seems to work on 0.9.5. Great!

#7 Updated by Toshi MARUYAMA almost 7 years ago

  • Category changed from UI to SCM

#8 Updated by Anonymous almost 5 years ago

This feature is implemented (as a side effect) by my patch #13487.

#9 Updated by Jean-Baptiste Barth over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Baptiste Barth
  • Resolution set to Wont fix
Actually I don't think homonyms should be merged automatically. I know this answer comes very late in this issue, but let's imagine the following case (which is a real case for me at work :/) :
  • first user commits with John <john.smith@foo.net>
  • second user commits with John <john.doe@foo.net>

It's pretty obvious those users are not the same person, they don't even share the same family name. But it will be very difficult to detect that. So now that we have committers<->users mapping that can be defined per repository, I guess people could rely on that (or even script that!) to fit their needs.

I close this for now but please re-open it if you strongly disagree.

#10 Updated by txemi M over 3 years ago

I would like not seeing this issue closed. I do not agree with the argument given above. I also think that there is no reliable way for redmine to guess identity mapping but I also think that this should not be done automatically. The administrator who added repository to some project should manually define the mapping.

Also available in: Atom PDF