Project

General

Profile

Actions
Copy link

Feature #20822

closed

No private issue notifications

Added by Karel Pičman over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Email notifications
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid

Description

Email notifications of private issues shouldn't be sent to all project members

Files

private_issue_notifications.diff (946 Bytes) private_issue_notifications.diff Karel Pičman, 2015-09-23 12:52
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 8 years ago

  • Subject changed from Private issue notifications to No private issue notifications
Actions
Copy link
 #2

Updated by Toshi MARUYAMA over 8 years ago

  • Tracker changed from Patch to Feature
Actions
Copy link
 #3

Updated by Toshi MARUYAMA over 8 years ago

Sorry, I cannot get your intention.
Your patch send mail to assignee, right?
Your patch change behavior.
I think it is better to add checkbox on issue form such as ChiliProject.
https://www.chiliproject.org/issues/310

Actions
Copy link
 #4

Updated by Karel Pičman over 8 years ago

My intention is related to PRIVATE issues only. While private issues are hidden to the project members except the author and the assignee, the email notifications are distributed to all project members. And that's wrong, I think.

Actions
Copy link
 #5

Updated by Toshi MARUYAMA over 8 years ago

Karel Pičman wrote:

While private issues are hidden to the project members except the author and the assignee,

It is not true.
Private issue visibility can be defined at role "Issues visibility".

Actions
Copy link
 #6

Updated by Karel Pičman over 8 years ago

You're right. From that perspective my patch is wrong. However, the problem persists. In case of an update of a private issue, all members of the project get notifications despite the fact they are not allowed to view the issue.

Actions
Copy link
 #7

Updated by Karel Pičman over 8 years ago

  • Status changed from New to Resolved

I see it now. That's a complete misunderstanding from my site. Sorry for your time. You can close it as Invalid.

Actions
Copy link
 #8

Updated by Toshi MARUYAMA over 8 years ago

Karel Pičman wrote:

all members of the project get notifications despite the fact they are not allowed to view the issue.

Really?

source:tags/3.1.1/app/models/issue.rb#L889

    # Remove users that can not view the issue
    notified.reject! {|user| !visible?(user)}
Actions
Copy link
 #9

Updated by Toshi MARUYAMA over 8 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Invalid

Thank you.

Actions
Copy link

Also available in: Atom PDF