Feature #22058

Show image attachments and repo entries instead of downloading them

Added by Jan from Planio www.plan.io almost 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Attachments
Target version:3.3.0
Resolution:Fixed

Description

For text file attachments and text files in a repository, we have a nice inline display in Redmine that even shows line numbers.

Images however are always just downloaded. It would be nice if they were displayed as well.

Patch #21847_ Let mobile header be fixed - Redmine 2016-02-17 16-39-27.png (115 KB) Jan from Planio www.plan.io, 2016-02-17 10:40

0001-Reduce-view-code-duplication-by-using-a-nested-layou.patch Magnifier (3.32 KB) Jan from Planio www.plan.io, 2016-02-17 10:47

0002-Whitespace-only-change.patch Magnifier (2.14 KB) Jan from Planio www.plan.io, 2016-02-17 10:47

image_preview_in_redmine.jpg (370 KB) Jan from Planio www.plan.io, 2016-02-17 10:47

0004-Whitespace-only.patch Magnifier (949 Bytes) Jan from Planio www.plan.io, 2016-02-17 10:47

0003-Add-inline-image-preview-display-for-attachments-and.patch Magnifier (4.97 KB) Jan from Planio www.plan.io, 2016-04-11 14:03

Associated revisions

Revision 15322
Added by Jean-Philippe Lang over 2 years ago

Reduce view code duplication by using a nested layout for file rendering (#22058).

Patch by Jan Schulz-Hofen.

Revision 15323
Added by Jean-Philippe Lang over 2 years ago

Whitespace only change (#22058).

Patch by Jan Schulz-Hofen.

Revision 15324
Added by Jean-Philippe Lang over 2 years ago

Add inline image preview/display for attachments and repository entries (#22058).

Patch by Jan Schulz-Hofen.

Revision 15325
Added by Jean-Philippe Lang over 2 years ago

Whitespace only change (#22058).

Patch by Jan Schulz-Hofen.

Revision 15327
Added by Jean-Philippe Lang over 2 years ago

Fix max width and adds a top margin (#22058).

Revision 15328
Added by Jean-Philippe Lang over 2 years ago

Fix test failures (#22058).

Revision 15551
Added by Jean-Philippe Lang over 2 years ago

Add missing links to images in issue history (#22058).

History

#1 Updated by Jan from Planio www.plan.io almost 3 years ago

  • Description updated (diff)

#2 Updated by Jan from Planio www.plan.io almost 3 years ago

Here's a patch series that adds this feature:

#3 Updated by Jan from Planio www.plan.io over 2 years ago

  • File deleted (0003-Add-inline-image-preview-display-for-attachments-and.patch)

#5 Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next minor release to 3.3.0

#6 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

#7 Updated by Krzysztof Zielonka almost 2 years ago

Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?

#8 Updated by Toshi MARUYAMA over 1 year ago

Krzysztof Zielonka wrote:

Is any reason to use download_named_attachment_url in app/views/attachments/image.html.erb instead download_named_attachment_path?

FTR: #25295

Also available in: Atom PDF