Defect #22967

markdown: special character like ' (quote) breaks wiki links

Added by Philippe Le Brouster over 1 year ago. Updated over 1 year ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Wiki
Target version:-
Resolution: Affected version:3.2.2

Description

Affected version: 3.1.5, 3.2.2, at least
To reproduce:

Explanation:

I'm trying to upgrade redmine from 2.4.2 to 3.1.5 (or 3.2.2) and I've an issue with the wiki links.

With the version 2.4.2, using quote "'" in the wiki links was working (using the redmine_redcarpet_formatter).

For example :

[[This is a link'test]]

With the version 3.1.5 or 3.2.2 the same code break the wiki link during html formatting. The output is something like

This is a link&

I suspect there is a problem during the text escaping because the function ``parse_wiki_links`` in app/helpers/application_helper consider that there is an anchor. The supposed anchor come from the html escaped form of the quote (which is &#39).

In French language, this is a major problem because the quote character is often used.

Regards,
Philippe Le Brouster.

link.png (11 KB) Toshi MARUYAMA, 2016-06-22 16:51

wiki_edit.png - Content when editing (5.87 KB) Philippe Le Brouster, 2016-06-23 14:55

wiki_content.png - Content when viewing (8.63 KB) Philippe Le Brouster, 2016-06-23 14:55

History

#1 Updated by Toshi MARUYAMA over 1 year ago

I cannot reproduce on vanilla Redmine 3.2.3 ruby 1.9.3p551 (2014-11-13 revision 48407) [x86_64-linux].

#2 Updated by Toshi MARUYAMA over 1 year ago

  • Status changed from New to Needs feedback

#3 Updated by Philippe Le Brouster over 1 year ago

Hi,

The problem exists only with the markdown text format. The textile format is ok.

Did you test with this markdown text format ?

I've just set a vanilla redmine 3.2.3 (tarball from the website). And I can reproduce this bug.

Content when editing

Content when viewing

Regards,
Philippe Le Brouster

#4 Updated by Toshi MARUYAMA over 1 year ago

  • Subject changed from Special character like ' (quote) breaks wiki links to markdown: special character like ' (quote) breaks wiki links
  • Status changed from Needs feedback to New

#5 Updated by Adrien Crivelli over 1 year ago

I am also affected by this bug on Redmine 3.0.0.

I'd say it should be quite high on the priority list, because it will break things for a lot of french users, and possibly other languages too. But it will also break in English, as seen in those examples:

Markdown input:

[[Jack & Coke]]
[[a "quoted" name]]
[[le français, c'est super]]
[[broken < less]]
[[broken > more]]
[[also <broken> link]]

Actual output:

Jack &amp; Coke
a &quot;quoted&quot; name
le français, c&
broken &lt; less
broken &gt; more
also link

Expected output:

Jack & Coke
a "quoted" name
le français, c'est super
broken < less
broken > more
also broken link

Also available in: Atom PDF