Patch #23027

Lighter colors for revision info

Added by Go MAEDA over 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

In RepositoriesController#revision screen, it is a little bit hard to find commit messages because there are many detailed information (e.g. ID, Parent, Child). Probably commit message is important information for many people, I think it should be more obvious.

This patch set lighter colors for revision info like journal details (see #20370) to make commit messages more obvious.

screenshot.png (35.8 KB) Go MAEDA, 2016-06-09 11:36

revision-info-lighter-color.diff Magnifier - patch (707 Bytes) Go MAEDA, 2016-06-09 14:16


Related issues

Related to Redmine - Patch #23146: Show revision details using the same structure and look f... Closed

History

#2 Updated by Go MAEDA over 1 year ago

  • Target version set to Candidate for next major release

#3 Updated by Toshi MARUYAMA over 1 year ago

LGTM.

#4 Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next major release to 3.4.0

#5 Updated by Marius BALTEANU over 1 year ago

For consistency, I would like to suggest three new changes to this patch:
  1. move the "Added by Jane Doe 5 months ago" line above the ID, Parent and Child information and add the bottom dotted border
  2. show the ID, Parent and Child with bullet points and indented to right in the same way how the issue attributes are shown in the journals
  3. show user avatar for commit author.

In this way, the commit message will have the same structure like the journal and it will be more easily for the user to found the information.

@Go MAEDA, if you agree with these proposals, I can update your patch or if it is not clear enough, I can make a print-screen with my suggestions.

#6 Updated by Go MAEDA over 1 year ago

Marius BALTEANU wrote:

For consistency, I would like to suggest three new changes to this patch:
  1. move the "Added by Jane Doe 5 months ago" line above the ID, Parent and Child information and add the bottom dotted border
  2. show the ID, Parent and Child with bullet points and indented to right in the same way how the issue attributes are shown in the journals
  3. show user avatar for commit author.

It would be great (most interesting thing for me is showing user's icon) but I think you would be better to create another issue because these features are much bigger improvements than my 3 lines patch.

#7 Updated by Marius BALTEANU over 1 year ago

I have added the patch to #23146.

Unfortunately, it is not compatible with your patch because I changed from table to ul lists and the rules from this patch applies to table. Please take a look on my changes and if you like them, maybe you replace the current ticket with that one or let me know how do you want to proceed.

Also, I made a mistake in my previous comment, the user avatar was already displayed in that page, but before the revision number instead of user.

#8 Updated by Go MAEDA over 1 year ago

  • Related to Patch #23146: Show revision details using the same structure and look from the journals details added

#9 Updated by Go MAEDA over 1 year ago

  • Target version deleted (3.4.0)

Marius BALTEANU wrote:

I have added the patch to #23146.

Thanks, your patch is much better than mine.

#10 Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed

Implemented as a part of #23146.

Also available in: Atom PDF