https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-06-09T12:16:50ZRedmineRedmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=714152016-06-09T12:16:50ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/16127">revision-info-lighter-color.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/16127/revision-info-lighter-color.diff">revision-info-lighter-color.diff</a> added</li></ul> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=714722016-06-13T01:10:46ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717292016-06-22T11:40:56ZToshi MARUYAMA
<ul></ul><p>LGTM.</p> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717322016-06-22T12:25:37ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>3.4.0</i></li></ul> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717352016-06-22T14:53:40ZMarius BÄ‚LTEANU
<ul></ul>For consistency, I would like to suggest three new changes to this patch:
<ol>
<li>move the "Added by Jane Doe 5 months ago" line above the ID, Parent and Child information and add the bottom dotted border</li>
<li>show the ID, Parent and Child with bullet points and indented to right in the same way how the issue attributes are shown in the journals</li>
<li>show user avatar for commit author.</li>
</ol>
<p>In this way, the commit message will have the same structure like the journal and it will be more easily for the user to found the information.</p>
<p>@Go MAEDA, if you agree with these proposals, I can update your patch or if it is not clear enough, I can make a print-screen with my suggestions.</p> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717412016-06-23T02:46:28ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
For consistency, I would like to suggest three new changes to this patch:
<ol>
<li>move the "Added by Jane Doe 5 months ago" line above the ID, Parent and Child information and add the bottom dotted border</li>
<li>show the ID, Parent and Child with bullet points and indented to right in the same way how the issue attributes are shown in the journals</li>
<li>show user avatar for commit author.</li>
</ol>
</blockquote>
<p>It would be great (most interesting thing for me is showing user's icon) but I think you would be better to create another issue because these features are much bigger improvements than my 3 lines patch.</p> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717462016-06-23T10:32:16ZMarius BÄ‚LTEANU
<ul></ul><p>I have added the patch to <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Show revision details using the same structure and look from the journals details (Closed)" href="https://www.redmine.org/issues/23146">#23146</a>.</p>
<p>Unfortunately, it is not compatible with your patch because I changed from table to ul lists and the rules from this patch applies to table. Please take a look on my changes and if you like them, maybe you replace the current ticket with that one or let me know how do you want to proceed.</p>
<p>Also, I made a mistake in my previous comment, the user avatar was already displayed in that page, but before the revision number instead of user.</p> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717822016-06-25T08:42:32ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/23146">Patch #23146</a>: Show revision details using the same structure and look from the journals details</i> added</li></ul> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=717832016-06-25T08:46:50ZGo MAEDA
<ul><li><strong>Target version</strong> deleted (<del><i>3.4.0</i></del>)</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I have added the patch to <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Show revision details using the same structure and look from the journals details (Closed)" href="https://www.redmine.org/issues/23146">#23146</a>.</p>
</blockquote>
<p>Thanks, your patch is much better than mine.</p> Redmine - Patch #23027: Lighter colors for revision infohttps://www.redmine.org/issues/23027?journal_id=732362016-09-04T04:35:14ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Implemented as a part of <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Show revision details using the same structure and look from the journals details (Closed)" href="https://www.redmine.org/issues/23146">#23146</a>.</p>