https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292016-07-15T12:16:47ZRedmineRedmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=722122016-07-15T12:16:47ZVictor Campos
<ul></ul><p>Good, I will try this.</p> Redmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=722152016-07-15T16:41:02ZVictor Campos
<ul></ul><p>Victor Campos wrote:</p>
<blockquote>
<p>Good, I will try this.</p>
</blockquote>
<p>It works here, thx =)</p> Redmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=722162016-07-16T02:00:42ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.3.1</i></li></ul><p>Looks good to me. Caching a value is reasonable. Setting target version to 3.3.1.</p>
<p>Here is a diff made from Stephane Evr's post.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: app/models/issue.rb
===================================================================
</span><span class="gd">--- app/models/issue.rb (revision 15663)
</span><span class="gi">+++ app/models/issue.rb (working copy)
</span><span class="p">@@ -574,8 +574,9 @@</span>
# Returns the custom_field_values that can be edited by the given user
def editable_custom_field_values(user=nil)
<span class="gi">+ read_only_attr_names_array = read_only_attribute_names(user)
</span> visible_custom_field_values(user).reject do |value|
<span class="gd">- read_only_attribute_names(user).include?(value.custom_field_id.to_s)
</span><span class="gi">+ read_only_attr_names_array.include?(value.custom_field_id.to_s)
</span> end
end
</code></pre> Redmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=726572016-08-12T03:16:36ZToshi MARUYAMA
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/72657/diff?detail_id=56427">diff</a>)</li></ul> Redmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=727792016-08-20T11:38:47ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Issues editable_custom_field_values method very slow for issues with many custom fields</i> to <i>Issue#editable_custom_field_values very slow for issues with many custom fields</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Change committed in <a class="changeset" title="Issue#editable_custom_field_values very slow for issues with many custom fields (#23334). Patch ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/15742">r15742</a>, thanks.</p> Redmine - Patch #23334: Issue#editable_custom_field_values very slow for issues with many custom fieldshttps://www.redmine.org/issues/23334?journal_id=731392016-08-31T17:00:27ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>