Patch #2367

show view/annotate/download link on repositories/entries and repositories/annotate view

Added by Go MAEDA almost 9 years ago. Updated almost 9 years ago.

Status:ClosedStart date:2008-12-20
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:0.8.1

Description

If I enter repositories/entry view by clicking by file name on repositories/revision view, I cannot move to repositories/annotate view directly and I always get frustrated.

This patch adds view/annotate/download link like same as repositories/changes.

link_to_view_and_annotate.diff Magnifier (2.6 KB) Go MAEDA, 2008-12-20 14:35

link_to_view_and_annotate_corrected-r2157.diff Magnifier - Corrected patch against r2157. (3.48 KB) Mischa The Evil, 2008-12-22 20:57

_link_to_functions.rhtml Magnifier (634 Bytes) Go MAEDA, 2008-12-23 04:10

screenshot.png (22.7 KB) Go MAEDA, 2008-12-23 04:10

Associated revisions

Revision 2167
Added by Jean-Philippe Lang almost 9 years ago

Show view/annotate/download links on repositories/entries and repositories/annotate views (#2367).

Revision 2188
Added by Jean-Philippe Lang almost 9 years ago

Do not show a link to the current annotate or view page (#2367).

History

#1 Updated by Mischa The Evil almost 9 years ago

Simple but very useful improvement... :thumbsup:

Though, your patch misses the new partial (app/views/repositories/_link_to_functions.rhtml). I'll upload a corrected patch-file against r2157 of the trunk.

#2 Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from New to Closed
  • Target version set to 0.8.1

Very usefull indeed, it's committed in r2167.
Thanks.

#3 Updated by Go MAEDA almost 9 years ago

Oh, I mistook to make patch. Thanks the new patch. And thank for JP's quick work.

But the partial I made is a little bit difrerent from it. Using 'link_to_if' instead of 'link_to', not to make link to same view. It helpful to avoid confusing novice user. Please see attached image.

#4 Updated by Mischa The Evil almost 9 years ago

Go MAEDA wrote:

  • File _link_to_functions.rhtml added

But the partial I made is a little bit difrerent from it. Using 'link_to_if' instead of 'link_to', not to make link to same view. It helpful to avoid confusing novice user.

Indeed, that looks even better especially and probably for the novice Redmine user. Doesn't make much sense indeed to provide a link to the actual current view... Thanks for letting know about this difference...

#5 Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from Reopened to Closed

Change committed in r2188. Thanks Go.

Also available in: Atom PDF