Defect #23777
closedLogin button is too thin on WebKit browsers
0%
Description
Affected version: trunk (r15595 and later)
Firefox:
No problem.
Chrome:
padding property of input#login-submit seems to be ineffective.
Files
Updated by Go MAEDA over 7 years ago
This is a patch to fix this issue: fix-login-button-is-too-thin.diff
Changes input[type="submit"] to button[type="submit"].
Updated by Toshi MARUYAMA over 7 years ago
I cannot see any problem on Windows 10 Chrome 53.0.2785.101 m (64-bit).
Updated by Go MAEDA over 7 years ago
Toshi MARUYAMA wrote:
I cannot see any problem on Windows 10 Chrome 53.0.2785.101 m (64-bit).
Thank you for checking on Windows. I tested on Windows after seeing your post and found that the problem can not be reproduced on Windows.
I reproduced this problem on:
- Mac OS X 10.11.6 - Chrome 52.0.2743.116 (64-bit)
- Mac OS X 10.11.6 - Safari 9.1.3 (11601.7.8)
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Needs feedback
Could we fix the style without having to change the DOM element from input to button?
Updated by Marius BĂLTEANU over 7 years ago
Jean-Philippe Lang wrote:
Could we fix the style without having to change the DOM element from input to button?
Attached an alternative patch that fixes this issue only from CSS. I chose to target all input elements with type submit to prevent further issues like this.
Updated by Jean-Philippe Lang over 7 years ago
- Assignee set to Go MAEDA
Thanks for the patch. Go, can you confirm the fix works for you?
Updated by Go MAEDA over 7 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Go MAEDA to Jean-Philippe Lang
Jean-Philippe Lang wrote:
Thanks for the patch. Go, can you confirm the fix works for you?
Thanks to Marius BALTEANU, the fix works completely for me.
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from Resolved to Closed
- Target version deleted (
3.4.0) - Resolution set to Fixed
Thanks for your feedback, the patch is committed.