https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292008-12-29T05:22:19ZRedmineRedmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=63262008-12-29T05:22:19ZKihyun Yun
<ul></ul><p>Sorry, this is not a defect but a new feature.</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=63302008-12-29T12:32:09ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Patch</i></li></ul> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=63432008-12-29T20:03:17ZEric Davis
<ul></ul><p>If this is applied, emails sent from Redmine should have the Reply-To field set to the "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" setting. Otherwise this would really break the <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> on several systems.</p>
<p>Assume email is sent from "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" and that as an actual email inbox with <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> setup.</p>
<ol>
<li>User A updates an issue</li>
<li>Users B and C get the email update</li>
<li>User B replies to the email. Since "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" was the sender, that would be the recipient of the email</li>
<li>Redmine receives the email and adds an issue note from User B</li>
<li>Users A and C get the email update</li>
</ol>
<p>Overriding "To:" would break this process at step 3, requiring User B to manually change the email recipient.</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=64542009-01-05T03:23:57ZKihyun Yun
<ul></ul><p>Eric Davis wrote:</p>
<blockquote>
<p>If this is applied, emails sent from Redmine should have the Reply-To field set to the "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" setting. Otherwise this would really break the <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> on several systems.</p>
<p>Assume email is sent from "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" and that as an actual email inbox with <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> setup.</p>
<ol>
<li>User A updates an issue</li>
<li>Users B and C get the email update</li>
<li>User B replies to the email. Since "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" was the sender, that would be the recipient of the email</li>
<li>Redmine receives the email and adds an issue note from User B</li>
<li>Users A and C get the email update</li>
</ol>
<p>Overriding "To:" would break this process at step 3, requiring User B to manually change the email recipient.</p>
</blockquote>
<p>Okay.<br />It is what I didn't care of. As you mentioned about it, "Reply-To:" header should be <a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a> only for <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> enabled systems.</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=67812009-01-20T06:39:32Zyoungseok yi
<ul></ul><p>Eric Davis wrote:</p>
<blockquote>
<p>If this is applied, emails sent from Redmine should have the Reply-To field set to the "<a class="email" href="mailto:redmine@domain.com">redmine@domain.com</a>" setting. Otherwise this would really break the <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a> on several systems.</p>
</blockquote>
<p>What if the mail from redmine composed as follows.</p>
<ul>
<li><strong>From</strong> : Author of the issue or note</li>
<li><strong>Reply-To</strong> : e-mail for <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/RedmineReceivingEmails"> Email Receiving</a></li>
</ul>
<p>The notified person can send comment by using 'Reply' of e-mail client.<br /><ins>Most of e-mail client will use Reply-To address to send reply</ins> and, it will not include From or CC from original e-mail (this process will not cause duplicate notification)</p>
<p>I think the email with sender as author and reply-to as receiving e-mail will be more clear in most cases. and it will not break the process.</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=92412009-05-14T10:43:49Zyoungseok yi
<ul></ul><p>ActionMailer seems to support <strong>reply_to</strong> (I've checked v2.2.2)<br />How about to consider this?</p>
<p>setting for administrator could be used also.</p>
<ul>
<li><strong>From</strong> as issue.author.mail, <strong>Reply-To</strong> as Setting.mail_from</li>
<li><strong>From</strong> as Setting.mail_from, <strong>Reply-To</strong> as Setting.mail_from</li>
</ul>
<p>p.s.<br />In the patch attached, is it possible to make from as e-mail address with name.<br /><pre>"Order Watcher <watcher@example.com>"</pre></p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=154732010-03-26T09:00:17ZGareth Sylvester-Bradley
<ul></ul><p>We have just migrated to Redmine from the data jail that was Savane and I have to say that this feature is one of the very few things that I miss. Like the OP, I'd like e-mail notifications that I receive about new issues, comments, etc. to appear to come from the author, in order to assist with appropriate filtering in my e-mail client.</p>
<p>Is it possible this feature can be included in the <a href="/versions/show/14">Redmine 1.0 release</a>?</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=200672010-09-07T18:41:04ZDaniel M
<ul><li><strong>File</strong> <a href="/attachments/4437">redmine-1.0.1-mail_from_pattern.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4437/redmine-1.0.1-mail_from_pattern.patch">redmine-1.0.1-mail_from_pattern.patch</a> added</li></ul><p>Allowing a customized From address is something really useful to have.</p>
<p>I need to have per project from address, so I made a quick patch to be able to replace a token with project id, if that exists.</p>
<p>It adds another field in config file and web interface: mail_from_pattern and if '%%projectid%%' is used in it then is replaced by project id (patch attached, maybe is useful for someone -- my first ruby and remine code, might not be the most optimal way of doing it).</p>
<p>I think the best would be to have this kind of pattern to generate From and Reply-to addresses, then all will be happy, I could see there is another request for using author name in From address: issue <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Authors name in from address of email notifications (Closed)" href="https://www.redmine.org/issues/5913">#5913</a>.</p>
<p>For example, useful tokens:<br />- project id and name<br />- author name and email</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=230952010-12-09T16:28:30ZDonald Loflin
<ul></ul><p>I want redmine to just put the sender's firstname & lastname in the notification email, but continue<br />to the use usual sending address.</p>
<p>e.g instead of From: <a class="email" href="mailto:redmine@myredminesystem.com">redmine@myredminesystem.com</a><br />use From: Donald Loflin <<a class="email" href="mailto:redmine@myredminesystem.com">redmine@myredminesystem.com</a>></p>
<p>Then in email, you'll easily see who it's from, but replies automatically go back to the system. That's how Request Tracker and some others implement it.</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=230972010-12-10T00:44:26ZDonald Loflin
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Well, I just implemented the way I wanted it - all it took was 2 lines of code:</p>
<pre><code>f = "#{journal.user} <#{Setting.mail_from}>" <br /> from f</code></pre>
<p>Add that into app/models/mailer.rb inside each of the notification functions - e.g issue_add, issue_edit, etc. (probably shouldn't be done for every notification, just certain ones)</p>
<p>In my mailer.rb (v1.0.3), I put that right before "recipients issue.recipients" which is followed by cc(issue.watcher_recipients - @recipients) and the "subject" assignment.</p>
<p>If I knew how to make patches I'd make one...maybe time to learn...</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=247172011-02-01T00:47:13ZDonald Loflin
<ul></ul><p>Someone wrote me that he couldn't get my mod to work - well, one problem, what I mentioned above only works for issue_edit. In issue_add, you must set "f = #{issue.author} <#{Setting.mail_from}>"</p>
<p>Here's some code snippets from the issue_add and issue_edit functions in mailer.rb, which implement "From: Joe User <<a class="email" href="mailto:redmine@myredmineserver.com">redmine@myredmineserver.com</a>>" (ie First/Last changes, but the email address in <>'s is always the defined "mail_from" address). <br /><pre>
def issue_add(issue)
redmine_headers 'Project' => issue.project.identifier,
'Issue-Id' => issue.id,
'Issue-Author' => issue.author.login
redmine_headers 'Issue-Assignee' => issue.assigned_to.login if issue.assigned_to
message_id issue
# DLOFLIN add, set from = "user name <sendaddress>"
f = "#{issue.author} <#{Setting.mail_from}>"
from f
# END DLOFLIN
def issue_edit(journal)
issue = journal.journalized.reload
redmine_headers 'Project' => issue.project.identifier,
'Issue-Id' => issue.id,
'Issue-Author' => issue.author.login
redmine_headers 'Issue-Assignee' => issue.assigned_to.login if issue.assigned_to
message_id journal
references issue
@author = journal.user
# DLOFLIN add, set from = "user name <sendaddress>"
f = "#{journal.user} <#{Setting.mail_from}>"
from f
# END DLOFLIN
</pre></p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=445022013-01-15T21:38:35ZJan Niggemann (redmine.org team member)jan.niggemann@redmine.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Closing this, status is resolved since 400 days and more (issue was last updated more than 400 days ago)...</p> Redmine - Patch #2406: In email notification, send a email with sender as authorhttps://www.redmine.org/issues/2406?journal_id=727382016-08-19T10:46:29ZToshi MARUYAMA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/5913">Feature #5913</a>: Authors name in from address of email notifications</i> added</li></ul>