https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-03-14T07:12:54ZRedmineRedmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772662017-03-14T07:12:54ZGo MAEDA
<ul></ul><p>I think that <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16087/entry/trunk/app/views/layouts/mailer.html.erb#L28">source:trunk/app/views/layouts/mailer.html.erb@16087#L28</a> should be updated if the proposed patch is merged.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772682017-03-14T07:53:10ZMarius BÄ‚LTEANU
<ul></ul><p>The proposed change looks good to me.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772692017-03-14T08:19:05ZGo MAEDA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I think that <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16087/entry/trunk/app/views/layouts/mailer.html.erb#L28">source:trunk/app/views/layouts/mailer.html.erb@16087#L28</a> should be updated if the proposed patch is merged.</p>
</blockquote>
<p>Sorry, the patch also updates mailer.html.erb. I missed it.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772702017-03-14T08:22:41ZJan from Planio www.plan.io
<ul><li><strong>File</strong> <a href="/attachments/17915">0001-Remove-initial-indentation-for-block-quotes.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/17915/0001-Remove-initial-indentation-for-block-quotes.patch">0001-Remove-initial-indentation-for-block-quotes.patch</a> added</li></ul><p>Thanks for your feedback, Go and Marius.</p>
<p>Sadly, I overlooked RTL support. Here's an updated patch including the proposed change for RTL writing systems, e.g. Arabic.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772712017-03-14T08:22:52ZJan from Planio www.plan.io
<ul><li><strong>File</strong> deleted (<del><i>0001-Remove-initial-indentation-for-block-quotes.patch</i></del>)</li></ul> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772772017-03-14T18:43:47ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Sounds good to me.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=772792017-03-15T00:48:32ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>3.4.0</i></li></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>Sounds good to me.</p>
</blockquote>
<p>Setting target version to 3.4.0.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=773442017-03-18T08:39:38ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Committed, thanks.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=797742017-07-05T20:26:20ZJP Vossen
<ul></ul><p>I disagree on this one. I prefer the indentation, which I think makes the quote stand out more. Any chance of making this optional?</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=797872017-07-05T21:16:59ZMischa The Evil
<ul></ul><p>JP Vossen wrote:</p>
<blockquote>
<p>[...] Any chance of making this optional?</p>
</blockquote>
<p>I don't think so. However, as this change consists of (mostly) theme-able CSS, it should be pretty easy to modify your theme to re-add the indentation.</p> Redmine - Patch #25320: Remove initial indentation of blockquotes for better readabilityhttps://www.redmine.org/issues/25320?journal_id=798052017-07-06T11:19:13Zbudo kaiman
<ul></ul><p>I'll +1 this, I think the change looks much better.</p>