Patch #25731

Use only one if with two conditions in issue show instead of two ifs (if in if)

Added by Marius BALTEANU 6 months ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:-

Description

I think that there are no reasons to use two ifs in source:trunk/app/views/issues/show.html.erb#L67. I propose to use only one with both conditions.

use_only_one_if.patch Magnifier (870 Bytes) Marius BALTEANU, 2017-05-01 16:39

Associated revisions

Revision 16581
Added by Toshi MARUYAMA 5 months ago

use only one if with two conditions in issue show instead of two ifs (if in if) (#25731)

Contributed by Marius BALTEANU.

History

#1 Updated by Go MAEDA 6 months ago

  • Target version set to 3.4.0

Thanks for the patch. Setting target version to 3.4.0.

#2 Updated by Toshi MARUYAMA 5 months ago

  • Status changed from New to Closed
  • Target version deleted (3.4.0)

Committed in trunk r16581, thanks.

Also available in: Atom PDF