https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-05-06T06:39:08ZRedmineRedmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=783942017-05-06T06:39:08ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/19648">Feature #19648</a>: Ability to show the Issue Assigne avatar instead of Author avatar</i> added</li></ul> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784162017-05-07T23:28:29ZAkiko Takano
<ul><li><strong>File</strong> <a href="/attachments/18254">25775-test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18254/25775-test.patch">25775-test.patch</a> added</li></ul><p>i’ve just tried above patch and it works fine. (Including responsive layout).<br />Since I made simple test for this patch, I hope this would be any help.</p>
<p>BTW, I’m using not Gravatar but local avatar plugin to display avatars, <a class="external" href="https://github.com/ncoders/redmine_local_avatars">https://github.com/ncoders/redmine_local_avatars</a>.<br />It seems this plugin does not append / override class setting, such as "gravatar-child" to second avatar icon (for assignee), so that icon for assignee does not appear at the expected position. (Not Lower right, but Upper right)</p>
<p>Of course, this is plugin’s reason, but if you could, please apply the same style to div.gravatar-with-child > img:nth-child(2).<br /><pre><code class="diff syntaxhl"><span class="p">hg diff public/stylesheets/application.css
</span><span class="gh">diff -r f5c7cc60ead2 public/stylesheets/application.css
</span><span class="gd">--- a/public/stylesheets/application.css Tue Apr 25 17:44:08 2017 +0000
</span><span class="gi">+++ b/public/stylesheets/application.css Mon May 08 08:14:29 2017 +0900
</span><span class="p">@@ -1313,6 +1313,18 @@</span>
margin: 0 6px 0 0;
}
+div.gravatar-with-child {
<span class="gi">+ position: relative;
+}
+
+img.gravatar-child, div.gravatar-with-child > img:nth-child(2) {
+ position: absolute;
+ top: 30px;
+ left: 30px;
+ border-radius: 20%;
+ border: 2px solid rgba(255, 255, 255, 0.9);
+}
</span>
</code></pre></p>
<p>Sorry, I failed to attach the patch for UI test. I'll attache it later.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784222017-05-08T07:24:22ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/18256">0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18256/0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch">0001-Show-assignee-s-icon-in-addition-to-author-s-icon.patch</a> added</li></ul><p>Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.<br />I have updated patch. Now it is compatible with the plugin.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784272017-05-08T11:54:09ZAkiko Takano
<ul><li><strong>File</strong> <a href="/attachments/18258">25775-ui-test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18258/25775-ui-test.patch">25775-ui-test.patch</a> added</li></ul><p>Maeda-san, thank you for picking up my request.<br />As I wrote above, attach an additional ui test, I’m glad if this would be help for reviewing or release planning.<br />(I tested with using Chromedriver and PhantomJS)</p>
<p>Sincerely,</p>
<p>Go MAEDA wrote:</p>
<blockquote>
<p>Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.<br />I have updated patch. Now it is compatible with the plugin.</p>
</blockquote> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784772017-05-10T13:54:44ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul><p>I am sure that this feature is useful for most users. And the feature got many likes on Twitter: <a class="external" href="https://twitter.com/g_maeda/status/861485901389504512">https://twitter.com/g_maeda/status/861485901389504512</a></p>
<p>Let's merge this feature into trunk along with tests by Akiko Takano. Setting target version to 3.4.0.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784792017-05-10T14:14:11ZMarius BĂLTEANU
<ul></ul><p>Just a note regarding the tests, IMHO, there are no reasons to have UI tests with PhantomJS (which are slower) for this feature. The same assertions can be made as well in a functional test.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784802017-05-11T00:58:10ZAkiko Takano
<ul></ul><p>Marius, thanks for your comment.</p>
<blockquote>
<p>The same assertions can be made as well in a functional test.</p>
</blockquote>
<p>Sorry, since I do not know what kind of test is required, I uploaded both types of test. <br />Looking forward to the next release.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=784872017-05-11T06:07:59ZMarius BĂLTEANU
<ul></ul><p>Akiko Takano wrote:</p>
<blockquote>
<p>Sorry, since I do not know what kind of test is required, I uploaded both types of test. <br />Looking forward to the next release.</p>
</blockquote>
<p>Ah, sorry, I didn't see the functional tests from 25775-test.patch. They look good to me.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=785052017-05-12T07:03:24ZJan from Planio www.plan.io
<ul></ul><p>I think this feature would be a great UI improvement!</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=785422017-05-14T16:38:21ZVasili Korol
<ul></ul><p>It would be very nice to have this feature. Sometimes users mistake the author's avatar for the assignee.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=791532017-06-10T12:27:10ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul><p>Patch is committed with fixed functional tests. UI tests are not appropriate for this indeed.<br />I've also removed the duplicate assignee avatar to clean up the display.<br />Thanks.</p> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=806292017-08-14T20:49:32ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/26689">Patch #26689</a>: Add title to author's and assignee's icon </i> added</li></ul> Redmine - Patch #25775: Show assignee's icon in addition to author's iconhttps://www.redmine.org/issues/25775?journal_id=806552017-08-15T15:01:31ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/26699">Defect #26699</a>: Anonymous user should have their icon</i> added</li></ul>