https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-05-15T19:56:37ZRedmineRedmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=785582017-05-15T19:56:37ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/18318">Screen Shot 2017-05-15 at 22.54.28.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18318/Screen%20Shot%202017-05-15%20at%2022.54.28.png">Screen Shot 2017-05-15 at 22.54.28.png</a> added</li><li><strong>File</strong> <a href="/attachments/18316">Screen Shot 2017-05-15 at 22.54.40.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18316/Screen%20Shot%202017-05-15%20at%2022.54.40.png">Screen Shot 2017-05-15 at 22.54.40.png</a> added</li><li><strong>File</strong> <a href="/attachments/18317">Screen Shot 2017-05-15 at 22.54.48.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18317/Screen%20Shot%202017-05-15%20at%2022.54.48.png">Screen Shot 2017-05-15 at 22.54.48.png</a> added</li></ul><p>I've attached 3 screenshots with the implementation.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=789102017-06-01T11:55:55ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.4.0</i></li></ul><p>The patch improve consistency of UI. Setting target version to 3.4.0.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=789342017-06-01T20:25:35ZMischa The Evil
<ul></ul>I've had a look at the screenshots and patches. My two cents on this proposal:
<ul>
<li>I find it more natural to have the 'Close completed versions' link rendered on the top-right (as it is a link that functions on all versions)</li>
<li>I also find it more natural to have the wiki 'Delete' link rendered aligned to the top-right, <em>above</em> the <code>div.box.tabular</code> (this in line with above; links that work on all the tab's items all on the top-right instead of on the bottom-right)</li>
</ul>
This is however:
<ul>
<li>more difficult to implement</li>
<li>very much a matter of taste, I think (making it a difficult thing to suit everyone's mileage)</li>
</ul> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=790562017-06-07T05:41:57ZMarius BĂLTEANU
<ul></ul><p>Thanks Mischa for reviewing this patch. If was only after me, I would move all the links to the top right for consistency with other screens. (even the New Item links). Getting back to your feedback, I'll be happy with any implementation that moves the links from the bottom to top.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=791042017-06-09T05:34:08ZMischa The Evil
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>If was only after me, I would move all the links to the top right for consistency with other screens. (even the New Item links).</p>
</blockquote>
<p>On <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Move all 'new item' links in project settings to above the item tables (Closed)" href="https://www.redmine.org/issues/24720#note-2">#24720#note-2</a>, I wrote the following about that:</p>
<blockquote>
<p>[...] I've also explored the (re-)use of the contextual div class for this purpose (as such tightening the consistency of new links throughout the app in both the front- ánd back-end) but found that it led to a, for me unacceptable, increase of traveled mouse distance.</p>
</blockquote>
<p>Marius BALTEANU wrote:</p>
<blockquote>
<p>[...] I'll be happy with any implementation that moves the links from the bottom to top.</p>
</blockquote>
<p>I understand. Can you look into incorporating my two notes into your proposed patch? With those covered, I'd say this is good enough so that this could be added still to <a class="version" href="https://www.redmine.org/versions/119">3.4.0</a> along with <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Move all 'new item' links in project settings to above the item tables (Closed)" href="https://www.redmine.org/issues/24720">#24720</a> and <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: UI inconsistencies on /enumerations/index view (Closed)" href="https://www.redmine.org/issues/24776">#24776</a>.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=792522017-06-17T07:40:23ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>3.4.0</i> to <i>Candidate for next minor release</i></li></ul><p>Please reassign when a solution that fits everyone's need is implemented.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=794822017-06-26T22:59:24ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/18606">manage_versions.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18606/manage_versions.png">manage_versions.png</a> added</li><li><strong>File</strong> <a href="/attachments/18607">move_left_bottom_links_from_project_settings_above.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18607/move_left_bottom_links_from_project_settings_above.patch">move_left_bottom_links_from_project_settings_above.patch</a> added</li></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>On <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Move all 'new item' links in project settings to above the item tables (Closed)" href="https://www.redmine.org/issues/24720#note-2">#24720#note-2</a>, I wrote the following about that:</p>
<blockquote>
<p>[...] I've also explored the (re-)use of the contextual div class for this purpose (as such tightening the consistency of new links throughout the app in both the front- ánd back-end) but found that it led to a, for me unacceptable, increase of traveled mouse distance.</p>
</blockquote></blockquote>
<p>I read you reasons and I'm agree with you, but from my point of view is more important to have the links/buttons in the same place in all screens. In other words, I prefer the consistency instead of saving some mouse distance for some actions that are not made very often. But as you said, it is very much a matter of taste.</p>
<blockquote>
<p>I understand. Can you look into incorporating my two notes into your proposed patch? With those covered, I'd say this is good enough so that this could be added still to <a class="version" href="https://www.redmine.org/versions/119">3.4.0</a> along with <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Move all 'new item' links in project settings to above the item tables (Closed)" href="https://www.redmine.org/issues/24720">#24720</a> and <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: UI inconsistencies on /enumerations/index view (Closed)" href="https://www.redmine.org/issues/24776">#24776</a>.</p>
</blockquote>
<p>I've uploaded a new patch that incorporates your two notes. <br /><img src="https://www.redmine.org/attachments/download/18606/manage_versions.png" alt="" /></p>
<p>Some technical notes:<br />- I tried to use the existing contextual class without adding new css class<br />- I moved the if conditions outside in order to not render empty contextual blocks.</p>
<p>As a overall conclusion, it is better than the actual implementation (with the bottom links), but I'm still not very happy with the new results (quite awkward to have a link top-left and one in top-right in the versions tab).</p>
<p>Initial patches can be removed.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=809162017-09-02T03:15:48ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.1.0</i></li></ul><p>Marius updated the patch. I am setting target version again.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=874462018-09-20T05:52:56ZMarius BĂLTEANU
<ul></ul><p>It is a small change, I would suggest to include it in <a class="version" href="https://www.redmine.org/versions/99">4.0.0</a> to get rid of the buttons under the tables/lists.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=874472018-09-20T06:21:38ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>It is a small change, I would suggest to include it in <a class="version" href="https://www.redmine.org/versions/99">4.0.0</a> to get rid of the buttons under the tables/lists.</p>
</blockquote>
<p>Indeed.</p>
<p>But the attached patch cannot be applied cleanly against the current trunk. Could you update the patch? I will commit the new patch when it is ready.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=874642018-09-20T18:04:41ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/21461">move_left_bottom_links_from_project_settings_above_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21461/move_left_bottom_links_from_project_settings_above_v2.patch">move_left_bottom_links_from_project_settings_above_v2.patch</a> added</li><li><strong>Assignee</strong> changed from <i>Marius BĂLTEANU</i> to <i>Go MAEDA</i></li></ul><p>Here it is.</p> Redmine - Patch #25853: Move left bottom links from project settings abovehttps://www.redmine.org/issues/25853?journal_id=874662018-09-20T22:31:12ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Committed. Thank you.</p>